Opened 6 years ago

Closed 6 years ago

#20796 closed enhancement (fixed)

py3 print : not tested cases, step 3

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: tscrim, jmantysalo, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 505d357 (Commits, GitHub, GitLab) Commit: 505d357482449524fb44489ed9d1979cd7c3bfc3
Dependencies: Stopgaps:

Status badges

Description

another small step towards python3

we are still not done with converting all print

Change History (9)

comment:1 Changed 6 years ago by chapoton

  • Branch set to public/20796
  • Commit set to aec30a67759c0b9c0cd7c80e924c6950d13a64c7
  • Status changed from new to needs_review

New commits:

aec30a6changing some print to python3 syntax, again

comment:2 Changed 6 years ago by git

  • Commit changed from aec30a67759c0b9c0cd7c80e924c6950d13a64c7 to ed93adc206ba2ba679d57cfb3bc461f7506f38b6

Branch pushed to git repo; I updated commit sha1. New commits:

ed93adctrac 20796 details in designs

comment:3 Changed 6 years ago by chapoton

  • Cc tscrim jmantysalo jdemeyer added

bot is green

comment:4 Changed 6 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I can take.

comment:5 follow-up: Changed 6 years ago by jmantysalo

  • Status changed from needs_review to needs_work

What is the meaning of a space at start on

print(' {:>{width}}'.format(c, width=width), end="")

You have changed while len(current_layer) > 0: to while len(current_layer):. It is OK, but isn't the Python way just while current_layer:?

IMO there should be a dot after "Install database_gap first. See optional packages".

There is an ' at "Gel'fand", I don't know why.

Tests passed on modified files.

comment:6 Changed 6 years ago by git

  • Commit changed from ed93adc206ba2ba679d57cfb3bc461f7506f38b6 to 505d357482449524fb44489ed9d1979cd7c3bfc3

Branch pushed to git repo; I updated commit sha1. New commits:

505d357trac 20796 some details

comment:7 in reply to: ↑ 5 ; follow-up: Changed 6 years ago by chapoton

Replying to jmantysalo:

What is the meaning of a space at start on

print(' {:>{width}}'.format(c, width=width), end="")

This is needed to have the table formatted as expected.

comment:8 in reply to: ↑ 7 Changed 6 years ago by jmantysalo

  • Status changed from needs_work to positive_review

Replying to chapoton:

Replying to jmantysalo:

What is the meaning of a space at start on

print(' {:>{width}}'.format(c, width=width), end="")

This is needed to have the table formatted as expected.

OK then.

comment:9 Changed 6 years ago by vbraun

  • Branch changed from public/20796 to 505d357482449524fb44489ed9d1979cd7c3bfc3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.