Opened 4 years ago

Closed 4 years ago

#20791 closed defect (fixed)

NumberField.extension() creates non-unique parents

Reported by: pbruin Owned by:
Priority: major Milestone: sage-7.3
Component: number fields Keywords:
Cc: Merged in:
Authors: Peter Bruin Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6b343ab (Commits) Commit: 6b343ab78ffc5aa054096ab3b1a1e88e0f0e00db
Dependencies: Stopgaps:

Description

The following should return True:

sage: K.<a> = NumberField(x^2 + 1)
sage: K.extension(x^2 - 2, 'b') is K.extension(x^2 - 2, 'b')
False

This happens because NumberField.extension() does not use the NumberField factory.

Change History (6)

comment:1 Changed 4 years ago by pbruin

  • Branch set to u/pbruin/20791-NumberField_extension
  • Commit set to f82dd33c1c2c96b40aba65e048634f8001318f7c
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit changed from f82dd33c1c2c96b40aba65e048634f8001318f7c to 56068f4f62e399464fd45feb322ad19c856f8a0c

Branch pushed to git repo; I updated commit sha1. New commits:

56068f4Trac 20791: fix doctest

comment:3 follow-up: Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

If you could change :trac:20791 to :trac:`20791`, then if the patchbot is happy, you can set a positive review on my behalf.

comment:4 Changed 4 years ago by git

  • Commit changed from 56068f4f62e399464fd45feb322ad19c856f8a0c to 6b343ab78ffc5aa054096ab3b1a1e88e0f0e00db

Branch pushed to git repo; I updated commit sha1. New commits:

6b343abTrac 20791: fix Trac reference formatting

comment:5 in reply to: ↑ 3 Changed 4 years ago by pbruin

  • Status changed from needs_review to positive_review

Replying to tscrim:

If you could change :trac:20791 to :trac:`20791`, then if the patchbot is happy, you can set a positive review on my behalf.

Done, thanks for the review.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/pbruin/20791-NumberField_extension to 6b343ab78ffc5aa054096ab3b1a1e88e0f0e00db
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.