Opened 5 years ago
Closed 4 years ago
#20778 closed enhancement (fixed)
Add certificate option to has_line_minor
Reported by:  tara  Owned by:  

Priority:  minor  Milestone:  sage8.0 
Component:  matroid theory  Keywords:  
Cc:  Stefan, yomcat  Merged in:  
Authors:  Tara Fife  Reviewers:  Stefan van Zwam 
Report Upstream:  N/A  Work issues:  
Branch:  608bc12 (Commits, GitHub, GitLab)  Commit:  608bc123e9ce531cf00a435c600b9b283885fa8f 
Dependencies:  Stopgaps: 
Description (last modified by )
Add an option to the has_line_minor
method of matroids to return a witness in case a minor is found.
Change History (16)
comment:1 Changed 5 years ago by
 Branch set to public/ticket/20778
comment:2 Changed 5 years ago by
 Commit set to d909a084578b8112e449b4de61935349896b75a3
 Status changed from new to needs_review
comment:3 Changed 5 years ago by
 Commit changed from d909a084578b8112e449b4de61935349896b75a3 to bddc173cb69188deec576e559245683d11c5f304
Branch pushed to git repo; I updated commit sha1. New commits:
bddc173  Added doctests and fixed errors.

comment:4 Changed 5 years ago by
 Description modified (diff)
 Priority changed from major to minor
 Type changed from PLEASE CHANGE to enhancement
comment:5 Changed 5 years ago by
 Reviewers set to Stefan van Zwam
 Status changed from needs_review to needs_work
No dashes in input description. I suggest the following:
 ``certificate``  (default: ``False``) if ``True`` returns ``(True, F)``, where ``F`` is a flat and ``self.minor(contractions=F)`` has a `U_{2,k}` restriction; or ``(False, None)``.
After that minor change, I'm happy with this ticket and will give a positive review.
comment:6 Changed 5 years ago by
 Commit changed from bddc173cb69188deec576e559245683d11c5f304 to e07d4f26182cc030be951c77343f03fd854e5b5d
Branch pushed to git repo; I updated commit sha1. New commits:
e07d4f2  Fixed documentation

comment:7 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:9 followup: ↓ 12 Changed 5 years ago by
 Status changed from positive_review to needs_work
Merge conflict in src/sage/matroids/matroid.pxd, possibly #21251
comment:10 Changed 5 years ago by
I'm not seeing this conflict; perhaps we need to wait until 7.4.beta2?
comment:11 Changed 4 years ago by
 Commit changed from e07d4f26182cc030be951c77343f03fd854e5b5d to 608bc123e9ce531cf00a435c600b9b283885fa8f
comment:12 in reply to: ↑ 9 Changed 4 years ago by
 Status changed from needs_work to needs_review
The apparent conflict was with #20689. There was no real conflict, but the modified lines were right next to each other. I think I've resolved it.
comment:13 Changed 4 years ago by
 Milestone changed from sage7.3 to sage8.0
 Status changed from needs_review to positive_review
LGTM.
comment:14 Changed 4 years ago by
Do I need to be concerned that a patchbot says that the build failed?
comment:15 Changed 4 years ago by
If you look at the patchbot log, you will see that the error is unrelated:
Error installing package gf2x1.1.p1
comment:16 Changed 4 years ago by
 Branch changed from public/ticket/20778 to 608bc123e9ce531cf00a435c600b9b283885fa8f
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Added the option to get a certificate