Opened 13 months ago

Closed 12 days ago

#20778 closed enhancement (fixed)

Add certificate option to has_line_minor

Reported by: tara Owned by:
Priority: minor Milestone: sage-8.0
Component: matroid theory Keywords:
Cc: Stefan, yomcat Merged in:
Authors: Tara Fife Reviewers: Stefan van Zwam
Report Upstream: N/A Work issues:
Branch: 608bc12 (Commits) Commit: 608bc123e9ce531cf00a435c600b9b283885fa8f
Dependencies: Stopgaps:

Description (last modified by Stefan)

Add an option to the has_line_minor method of matroids to return a witness in case a minor is found.

Change History (16)

comment:1 Changed 13 months ago by tara

  • Branch set to public/ticket/20778

comment:2 Changed 13 months ago by tara

  • Commit set to d909a084578b8112e449b4de61935349896b75a3
  • Status changed from new to needs_review

New commits:

d909a08Added the option to get a certificate

comment:3 Changed 13 months ago by git

  • Commit changed from d909a084578b8112e449b4de61935349896b75a3 to bddc173cb69188deec576e559245683d11c5f304

Branch pushed to git repo; I updated commit sha1. New commits:

bddc173Added doctests and fixed errors.

comment:4 Changed 12 months ago by Stefan

  • Description modified (diff)
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to enhancement

comment:5 Changed 12 months ago by Stefan

  • Reviewers set to Stefan van Zwam
  • Status changed from needs_review to needs_work

No dashes in input description. I suggest the following:

        - ``certificate`` -- (default: ``False``) if ``True`` returns ``(True, F)``,
          where ``F`` is a flat and ``self.minor(contractions=F)`` has a
          `U_{2,k}` restriction; or ``(False, None)``.

After that minor change, I'm happy with this ticket and will give a positive review.

comment:6 Changed 12 months ago by git

  • Commit changed from bddc173cb69188deec576e559245683d11c5f304 to e07d4f26182cc030be951c77343f03fd854e5b5d

Branch pushed to git repo; I updated commit sha1. New commits:

e07d4f2Fixed documentation

comment:7 Changed 12 months ago by tara

  • Status changed from needs_work to needs_review

comment:8 Changed 10 months ago by Stefan

  • Status changed from needs_review to positive_review

I'm happy now.

comment:9 follow-up: Changed 10 months ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict in src/sage/matroids/matroid.pxd, possibly #21251

comment:10 Changed 10 months ago by Stefan

I'm not seeing this conflict; perhaps we need to wait until 7.4.beta2?

comment:11 Changed 5 weeks ago by git

  • Commit changed from e07d4f26182cc030be951c77343f03fd854e5b5d to 608bc123e9ce531cf00a435c600b9b283885fa8f

Branch pushed to git repo; I updated commit sha1. New commits:

c172f55Added the option to get a certificate
392d8c2Added doctests and fixed errors.
63218deFixed documentation
608bc12Merge branch 'public/ticket/20778' of git://trac.sagemath.org/sage into t/20778/public/ticket/20778

comment:12 in reply to: ↑ 9 Changed 5 weeks ago by zgershkoff

  • Status changed from needs_work to needs_review

The apparent conflict was with #20689. There was no real conflict, but the modified lines were right next to each other. I think I've resolved it.

comment:13 Changed 3 weeks ago by tscrim

  • Milestone changed from sage-7.3 to sage-8.0
  • Status changed from needs_review to positive_review

LGTM.

comment:14 Changed 3 weeks ago by zgershkoff

Do I need to be concerned that a patchbot says that the build failed?

comment:15 Changed 3 weeks ago by tscrim

If you look at the patchbot log, you will see that the error is unrelated:

Error installing package gf2x-1.1.p1
Last edited 3 weeks ago by tscrim (previous) (diff)

comment:16 Changed 12 days ago by vbraun

  • Branch changed from public/ticket/20778 to 608bc123e9ce531cf00a435c600b9b283885fa8f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.