Opened 5 years ago
Closed 4 years ago
#20771 closed enhancement (fixed)
Modules of vector fields as Lie algebroids
Reported by:  tscrim  Owned by:  tscrim 

Priority:  major  Milestone:  sage7.5 
Component:  geometry  Keywords:  lie algebras, days74 
Cc:  egourgoulhon  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  2f1d037 (Commits, GitHub, GitLab)  Commit:  2f1d03736d98ad1d8088cfa7b8278ddcfbc9a393 
Dependencies:  #19092, #20770  Stopgaps: 
Description (last modified by )
This ticket adds Lie bracket to vector fields, giving the structure of Lie algebroid to the set X(M) of all vector fields over the manifold M.
Change History (20)
comment:1 Changed 5 years ago by
 Branch set to public/manifolds/lie_algebras20771
 Commit set to bb95148a2356f26157303f7fc9e4fd204b1fed15
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Dependencies changed from #16820, #20770 to #16820, #19092, #20770
 Status changed from needs_review to positive_review
Failing test suite will be handled by improvements #19092.
comment:3 Changed 5 years ago by
 Commit changed from bb95148a2356f26157303f7fc9e4fd204b1fed15 to 6b71b13d4fbda757edde6cbbcb0531f08937c64b
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
6b71b13  Removing finitedimensionality for generic vectorfield module.

comment:4 Changed 5 years ago by
 Status changed from needs_review to positive_review
comment:5 Changed 5 years ago by
 Status changed from positive_review to needs_work
This is not a Lie algebra over the scalar field (only over the base field); it fails to be bilinear.
comment:6 Changed 5 years ago by
We will change this to be a Lie algebroid.
comment:7 Changed 5 years ago by
 Commit changed from 6b71b13d4fbda757edde6cbbcb0531f08937c64b to 96f09abe606bcb1bea50989b1a30e97cb5e92626
comment:8 Changed 5 years ago by
 Dependencies changed from #16820, #19092, #20770 to #19092, #20770
I've changed this as per our discussions and the forced push is to remove the dependency of #16820.
comment:9 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:10 Changed 5 years ago by
 Commit changed from 96f09abe606bcb1bea50989b1a30e97cb5e92626 to 72396ddfe2900d9ca95c870114c1ba451f3d2b64
Branch pushed to git repo; I updated commit sha1. New commits:
2150a43  Correct doctests in vector fields after the merge of #20770 in sage 7.3.beta3

3b1b794  Fix doctests in tangent spaces after the merge of #20770 in sage 7.3.beta3

72396dd  Merge with latest #19092 to fix doctests after the merge of #20770 in sage 7.3.beta3

comment:11 Changed 5 years ago by
 Status changed from needs_review to positive_review
Looks good to me, thanks (the above commits are just to fix doctests in dependency tickets).
comment:12 Changed 5 years ago by
 Commit changed from 72396ddfe2900d9ca95c870114c1ba451f3d2b64 to 835b29379b600d8c1511662654abd7ec7e4c48d5
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
3ab0af0  Initial reviewer changes.

d7ad8e1  Merge branch 'public/manifolds/diff_manif_tensor_fields' of git://trac.sagemath.org/sage into sage 7.3.beta5

dcb08fc  Decrease doctest times in tensor fields; remove xder from the global namespace

c70792e  Update tangent spaces to the latest version of #18843 (vector fields)

835b293  Update Lie algebroids to the latest version of #18843 (vector fields)

comment:13 Changed 5 years ago by
 Milestone changed from sage7.3 to sage7.4
 Status changed from needs_review to positive_review
Setting back to positive review (since the latest commit simply propagates changes in the dependency ticket #19092)
comment:14 Changed 4 years ago by
 Commit changed from 835b29379b600d8c1511662654abd7ec7e4c48d5 to a5ab39a35019da581e4a813381ed07aea6280558
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:
58f7fb9  Merge branch 'develop' into public/manifolds/diff_manif_tensor_fields

3e73095  Merge branch 'develop' into public/manifolds/diff_manif_tensor_fields

4955c3c  Final review of everything.

7cf4ff4  Merge branch 'public/manifolds/diff_manif_tensor_fields' of trac.sagemath.org:sage into public/manifolds/diff_manif_tensor_fields

58ae506  Merge branch 'public/manifolds/diff_manif_tensor_fields' of git://trac.sagemath.org/sage into Sage 7.4.beta6

8219403  Fix documentation error; change in TensorField comparison to zero

a841f79  Python 3 compatible syntax in tensor fields

5a5f400  Slight change in TensorField.__eq__ (comparison to zero)

98efa66  Update tangent spaces to the final version of the dependency ticket #18843

a5ab39a  Update Lie algebroids to the latest version of the dependency ticket #19092

comment:15 Changed 4 years ago by
 Description modified (diff)
 Status changed from needs_review to positive_review
 Summary changed from Put vector fields in the category of Lie algebras to Modules of vector fields as Lie algebroids
Setting back to positive review, since the latest commit simply propagates changes in the dependency ticket #19092
comment:16 Changed 4 years ago by
 Commit changed from a5ab39a35019da581e4a813381ed07aea6280558 to 6af8ad273b32323c3f6129b37f8b22d6bc3fbdf2
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
8860387  Add missing reference Lee13

fb7f4dd  Bibliographic references for tensor fields moved to the master file

8205dca  Update tangent spaces to the last change (adding a missing reference) in the dependency ticket #18843

785300b  Bibliographic references for tangent spaces moved to the master file created by #21454

6af8ad2  Bibliographic references for vector field modules as Lie algebroids moved to the master file created by #21454

comment:17 Changed 4 years ago by
 Status changed from needs_review to positive_review
Setting back to positive review, since the latest commit simply solves a merge conflict with #21454.
comment:18 Changed 4 years ago by
 Commit changed from 6af8ad273b32323c3f6129b37f8b22d6bc3fbdf2 to 2f1d03736d98ad1d8088cfa7b8278ddcfbc9a393
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
4ce1118  Merge branch 'public/manifolds/diff_manif_tangent_spaces' of git://trac.sagemath.org/sage into public/manifolds/diff_manif_tangent_spaces

567b892  Doing some reviewer changes for #19092.

05f8cc7  A little bit of extra cleanup.

23eb9d8  Correct doctest and documentation in tangent spaces

b4a4530  Use sphinx_plot for 3D plots in the documentation of charts and vector fields

ff6eb09  Name of argument 'nb_values' in RealChart.plot changed to 'number_values'.

2f1d037  Update Lie algebroids to the latest version of tangent spaces

comment:19 Changed 4 years ago by
 Milestone changed from sage7.4 to sage7.5
 Status changed from needs_review to positive_review
Setting back to positive review, since the latest commit simply propagates changes in the dependency ticket #19092
comment:20 Changed 4 years ago by
 Branch changed from public/manifolds/lie_algebras20771 to 2f1d03736d98ad1d8088cfa7b8278ddcfbc9a393
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
Parsing the input so that it uses the indexing set.
Merge branch 'public/lie_algebras/fd_structure_coeff16820' in 7.0.rc1
trac #16820 correct the spelling of Cartesian
Merge branch 'public/lie_algebras/fd_structure_coeff16820' into 7.3.b2
Fixing trivial doctest failures.
Implementing a better way to compare indices.
Merge branch 'public/lie_algebras/fd_structure_coeff16820' into public/manifolds/lie_algebrasTBA
Added list of basis and finitedimensionality to finite rank free modules.
Merge branch 'public/modules/add_category_support_finite_rank_free_modules20770' into public/manifolds/lie_algebrasTBA
Adding vector field module to the category of Lie algebras.