Opened 3 years ago

Closed 3 years ago

#20763 closed enhancement (fixed)

Euler numbers via flint

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: combinatorics Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 510a91d (Commits) Commit: 510a91dcb68a46563e8776f4c2a1b2d99c93bcad
Dependencies: Stopgaps:

Description (last modified by chapoton)

euler numbers currently use the slow maxima pexpect interface

they can be much faster using flint

for a possible follow-up, see #17770

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/20763
  • Cc tscrim jmantysalo added
  • Commit set to 510a91dcb68a46563e8776f4c2a1b2d99c93bcad
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

510a91duse flint for euler numbers

comment:2 Changed 3 years ago by tscrim

Can you give some reasoning why it is 1000 for the cut-off for sig_on/sig_off?

comment:3 Changed 3 years ago by chapoton

I just copied that from the code of another function in flint/arith.

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Guess they consider that a good cutoff bound for speed for small values. Nor can I fault it:

sage: %time euler_number(10000)
CPU times: user 46.3 ms, sys: 0 ns, total: 46.3 ms
Wall time: 46.2 ms
# Too long to put here

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/20763 to 510a91dcb68a46563e8776f4c2a1b2d99c93bcad
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.