Opened 6 years ago

Closed 6 years ago

#20742 closed defect (fixed)

Upgrade to pynac-0.6.7

Reported by: Ralf Stephan Owned by:
Priority: major Milestone: sage-7.3
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 28c9671 (Commits, GitHub, GitLab) Commit: 28c967189fa05f1e986aff0e213a84a44e9cc0c0
Dependencies: Stopgaps:

Status badges

Description (last modified by Ralf Stephan)

pynac-0.6.7 has:

https://github.com/pynac/pynac/releases/download/pynac-0.6.7/pynac-0.6.7.tar.bz2

A minor hypothetical issue is that, although people with giac can switch off compilation of this code using the --with-giac=no configure option, the resulting binary will fail the one giac-specific GCD doctest because the doctests by default will still have the giac option turned on (because giac is still installed in Sage). You can work around this by giving explicit optional options to sage -t.

Change History (13)

comment:1 Changed 6 years ago by Ralf Stephan

Branch: u/rws/upgrade_to_pynac_0_6_6

comment:2 Changed 6 years ago by Ralf Stephan

Authors: Ralf Stephan
Commit: ddecdf93941dc3c57619b6c512f0e75960697c89
Status: newneeds_review

New commits:

f8cda51version/chksum
ddecdf9doc / doctest changes

comment:3 Changed 6 years ago by Ralf Stephan

Description: modified (diff)

comment:4 Changed 6 years ago by Ralf Stephan

Status: needs_reviewneeds_work

comment:5 Changed 6 years ago by git

Commit: ddecdf93941dc3c57619b6c512f0e75960697c89ca11f417d8be7ab240002f5758413a690309f701

Branch pushed to git repo; I updated commit sha1. New commits:

ca11f41add reflection doctests

comment:6 Changed 6 years ago by Ralf Stephan

Description: modified (diff)
Status: needs_workneeds_review
Summary: Upgrade to pynac-0.6.6Upgrade to pynac-0.6.7

The blocker (and other things) should be fixed. Please review.

comment:7 Changed 6 years ago by git

Commit: ca11f417d8be7ab240002f5758413a690309f70150b6a1694d5c51f97d6c2639cc37c373d5c5bd6b

Branch pushed to git repo; I updated commit sha1. New commits:

50b6a16new version/chksum

comment:8 Changed 6 years ago by Ralf Stephan

Description: modified (diff)

comment:9 Changed 6 years ago by git

Commit: 50b6a1694d5c51f97d6c2639cc37c373d5c5bd6b28c967189fa05f1e986aff0e213a84a44e9cc0c0

Branch pushed to git repo; I updated commit sha1. New commits:

28c9671chksum change

comment:10 Changed 6 years ago by Ralf Stephan

Checked that the github tarball content is ok. I seem to have made again the chksum from a different tarball in the previous commit. I also have two tarballs as example with the same content and different shasum, so this seems a problem with nondeterministic compression.

comment:11 Changed 6 years ago by Travis Scrimshaw

IIRC, the checksum also depends on when the tarball was created.

comment:12 Changed 6 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Everything seems to be okay to me.

comment:13 Changed 6 years ago by Volker Braun

Branch: u/rws/upgrade_to_pynac_0_6_628c967189fa05f1e986aff0e213a84a44e9cc0c0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.