Opened 3 years ago
Closed 3 years ago
#20742 closed defect (fixed)
Upgrade to pynac-0.6.7
| Reported by: | rws | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-7.3 |
| Component: | packages: standard | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Ralf Stephan | Reviewers: | Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 28c9671 (Commits) | Commit: | 28c967189fa05f1e986aff0e213a84a44e9cc0c0 |
| Dependencies: | Stopgaps: |
Description (last modified by )
pynac-0.6.7 has:
- fix trig function arg reflection (#20752)
- fix Hermite / Gegenbauer evalf
- fix Py3 compile
- fix clang compile errors
- install pynac-config.h instead of config.h to prevent duplicate defines
- fix internal binomial of noninteger
- optionally use giac for GCD:
- fixes rare GCD bug (#10284)
- allow full symbolic GCD
- increase performance by one order of magnitude (see https://github.com/pynac/pynac/wiki/Symbench-and-other-benchmarks#gcd-benchmarks
https://github.com/pynac/pynac/releases/download/pynac-0.6.7/pynac-0.6.7.tar.bz2
A minor hypothetical issue is that, although people with giac can switch off compilation of this code using the --with-giac=no configure option, the resulting binary will fail the one giac-specific GCD doctest because the doctests by default will still have the giac option turned on (because giac is still installed in Sage). You can work around this by giving explicit optional options to sage -t.
Change History (13)
comment:1 Changed 3 years ago by
- Branch set to u/rws/upgrade_to_pynac_0_6_6
comment:2 Changed 3 years ago by
- Commit set to ddecdf93941dc3c57619b6c512f0e75960697c89
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Description modified (diff)
comment:4 Changed 3 years ago by
- Status changed from needs_review to needs_work
Blocker reported: https://github.com/pynac/pynac/issues/182
comment:5 Changed 3 years ago by
- Commit changed from ddecdf93941dc3c57619b6c512f0e75960697c89 to ca11f417d8be7ab240002f5758413a690309f701
Branch pushed to git repo; I updated commit sha1. New commits:
| ca11f41 | add reflection doctests
|
comment:6 Changed 3 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
- Summary changed from Upgrade to pynac-0.6.6 to Upgrade to pynac-0.6.7
The blocker (and other things) should be fixed. Please review.
comment:7 Changed 3 years ago by
- Commit changed from ca11f417d8be7ab240002f5758413a690309f701 to 50b6a1694d5c51f97d6c2639cc37c373d5c5bd6b
Branch pushed to git repo; I updated commit sha1. New commits:
| 50b6a16 | new version/chksum
|
comment:8 Changed 3 years ago by
- Description modified (diff)
comment:9 Changed 3 years ago by
- Commit changed from 50b6a1694d5c51f97d6c2639cc37c373d5c5bd6b to 28c967189fa05f1e986aff0e213a84a44e9cc0c0
Branch pushed to git repo; I updated commit sha1. New commits:
| 28c9671 | chksum change
|
comment:10 Changed 3 years ago by
Checked that the github tarball content is ok. I seem to have made again the chksum from a different tarball in the previous commit. I also have two tarballs as example with the same content and different shasum, so this seems a problem with nondeterministic compression.
comment:11 Changed 3 years ago by
IIRC, the checksum also depends on when the tarball was created.
comment:12 Changed 3 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Everything seems to be okay to me.
comment:13 Changed 3 years ago by
- Branch changed from u/rws/upgrade_to_pynac_0_6_6 to 28c967189fa05f1e986aff0e213a84a44e9cc0c0
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
version/chksumdoc / doctest changes