Opened 3 years ago

Closed 3 years ago

#20742 closed defect (fixed)

Upgrade to pynac-0.6.7

Reported by: rws Owned by:
Priority: major Milestone: sage-7.3
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 28c9671 (Commits) Commit: 28c967189fa05f1e986aff0e213a84a44e9cc0c0
Dependencies: Stopgaps:

Description (last modified by rws)

pynac-0.6.7 has:

https://github.com/pynac/pynac/releases/download/pynac-0.6.7/pynac-0.6.7.tar.bz2

A minor hypothetical issue is that, although people with giac can switch off compilation of this code using the --with-giac=no configure option, the resulting binary will fail the one giac-specific GCD doctest because the doctests by default will still have the giac option turned on (because giac is still installed in Sage). You can work around this by giving explicit optional options to sage -t.

Change History (13)

comment:1 Changed 3 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_6_6

comment:2 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to ddecdf93941dc3c57619b6c512f0e75960697c89
  • Status changed from new to needs_review

New commits:

f8cda51version/chksum
ddecdf9doc / doctest changes

comment:3 Changed 3 years ago by rws

  • Description modified (diff)

comment:4 Changed 3 years ago by rws

  • Status changed from needs_review to needs_work

comment:5 Changed 3 years ago by git

  • Commit changed from ddecdf93941dc3c57619b6c512f0e75960697c89 to ca11f417d8be7ab240002f5758413a690309f701

Branch pushed to git repo; I updated commit sha1. New commits:

ca11f41add reflection doctests

comment:6 Changed 3 years ago by rws

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Summary changed from Upgrade to pynac-0.6.6 to Upgrade to pynac-0.6.7

The blocker (and other things) should be fixed. Please review.

comment:7 Changed 3 years ago by git

  • Commit changed from ca11f417d8be7ab240002f5758413a690309f701 to 50b6a1694d5c51f97d6c2639cc37c373d5c5bd6b

Branch pushed to git repo; I updated commit sha1. New commits:

50b6a16new version/chksum

comment:8 Changed 3 years ago by rws

  • Description modified (diff)

comment:9 Changed 3 years ago by git

  • Commit changed from 50b6a1694d5c51f97d6c2639cc37c373d5c5bd6b to 28c967189fa05f1e986aff0e213a84a44e9cc0c0

Branch pushed to git repo; I updated commit sha1. New commits:

28c9671chksum change

comment:10 Changed 3 years ago by rws

Checked that the github tarball content is ok. I seem to have made again the chksum from a different tarball in the previous commit. I also have two tarballs as example with the same content and different shasum, so this seems a problem with nondeterministic compression.

comment:11 Changed 3 years ago by tscrim

IIRC, the checksum also depends on when the tarball was created.

comment:12 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Everything seems to be okay to me.

comment:13 Changed 3 years ago by vbraun

  • Branch changed from u/rws/upgrade_to_pynac_0_6_6 to 28c967189fa05f1e986aff0e213a84a44e9cc0c0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.