Opened 7 years ago

Closed 7 years ago

#20713 closed enhancement (fixed)

use six to import builtins (step 2/2)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: tscrim, jdemeyer, jmantysalo, embray Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a63248e (Commits, GitHub, GitLab) Commit: a63248edcc6653b828c858fa723f24847f16c720
Dependencies: Stopgaps:

GitHub link to the corresponding issue


another bunch of py3 compatible imports of builtins

Change History (4)

comment:1 Changed 7 years ago by chapoton

Branch: public/20713
Cc: tscrim jdemeyer jmantysalo added
Commit: a63248edcc6653b828c858fa723f24847f16c720
Status: newneeds_review

New commits:

0cbd8e2use from six.moves.builtins import
a63248euse from six.moves.builtins, details of imports

comment:2 Changed 7 years ago by chapoton

Cc: embray added

ping ?

comment:3 Changed 7 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

I wonder how much these imports of __builtin__ are really needed (i.e., we can't get rid of by just renaming some variables). Anyways, this works for now.

comment:4 Changed 7 years ago by vbraun

Branch: public/20713a63248edcc6653b828c858fa723f24847f16c720
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.