Opened 5 years ago

Closed 5 years ago

#20711 closed defect (fixed)

Do not iterate in pretty_print

Reported by: Braun Owned by:
Priority: major Milestone: sage-7.3
Component: user interface Keywords: sd74
Cc: dkrenn Merged in:
Authors: Volker Braun Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6fafd06 (Commits, GitHub, GitLab) Commit: 6fafd06f6adc8621e064d31b948b4a8b744f699b
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

We want

sage: pretty_print(GF(2))
\newcommand{\Bold}[1]{\mathbf{#1}}\Bold{F}_{2}

instead of iterating over the elements of GF(2)

Change History (6)

comment:1 Changed 5 years ago by vbraun

  • Branch set to u/vbraun/do_not_iterate_in_pretty_print

comment:2 Changed 5 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 64dc304ed5d3bf9d417e28ab2f406f72ec9cd20a
  • Component changed from PLEASE CHANGE to user interface
  • Description modified (diff)
  • Keywords sd74 added
  • Reporter changed from vbraun to Braun
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

64dc304Do not unwrap iterators/generators in pretty_print

comment:3 Changed 5 years ago by dkrenn

  • Cc dkrenn added

comment:4 Changed 5 years ago by git

  • Commit changed from 64dc304ed5d3bf9d417e28ab2f406f72ec9cd20a to 6fafd06f6adc8621e064d31b948b4a8b744f699b

Branch pushed to git repo; I updated commit sha1. New commits:

6fafd06Fix failing doctest

comment:5 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, lgtm

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/vbraun/do_not_iterate_in_pretty_print to 6fafd06f6adc8621e064d31b948b4a8b744f699b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.