Opened 5 years ago

Closed 5 years ago

#20709 closed enhancement (fixed)

py3 print in the doc : almost final fine tuning

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 6ef822d (Commits, GitHub, GitLab) Commit: 6ef822df61a926d6be0fb7a420fed4d644641ef7
Dependencies: Stopgaps:

Status badges

Description

according to the patchbot testing of #20668,

there remains a handful of problems in the documentation concerning python(3 compatibility for print. Let us correct all of them, except for one file in the tests for the French book.

Change History (6)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20709
  • Cc tscrim jmantysalo added
  • Commit set to 6ef822df61a926d6be0fb7a420fed4d644641ef7
  • Status changed from new to needs_review

New commits:

6ef822d(almost) final tuning of py3-compatible print in the documentation

comment:2 Changed 5 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I can look this. Btw, what is "2009 MBP"? Google founds MacBook? Pro, is it that?

comment:3 Changed 5 years ago by jmantysalo

This is OK. You can set positive_review.

If you want, you can also remove # long time (22s on 2009 MBP). It took 0,00 seconds on Optiplex 7010. CORRECTION: The timing was from cached result, and # long time is still needed.

Last edited 5 years ago by jmantysalo (previous) (diff)

comment:4 Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, thanks Jori. I will leave the "long time" for the moment.

comment:5 Changed 5 years ago by tscrim

I can confirm the faster time on my laptop (~3 seconds), but it was long enough that IMO it should remain # long time. (We've come a long way in 6 years :P)

comment:6 Changed 5 years ago by vbraun

  • Branch changed from public/20709 to 6ef822df61a926d6be0fb7a420fed4d644641ef7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.