Opened 5 years ago

Closed 5 years ago

#20704 closed enhancement (fixed)

py3 print : not tested cases, step 2

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords: days74
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6dc2024 (Commits, GitHub, GitLab) Commit: 6dc2024e02a52c80aaa07f295f23bdcef660c1a2
Dependencies: Stopgaps:

Status badges

Description

There remains some python2-only print, because they were not tested anywhere.

Let us remove them in small bunches.

Change History (11)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20704
  • Commit set to 084b43afcb67e119ce0275c2d69436bf86326480
  • Status changed from new to needs_review

New commits:

084b43apython 3 print, taking care of some of the not-tested instances

comment:2 Changed 5 years ago by git

  • Commit changed from 084b43afcb67e119ce0275c2d69436bf86326480 to 719fadf543c94a63fa6b18847b6b8ab8b8e3a6bd

Branch pushed to git repo; I updated commit sha1. New commits:

719fadftrac 20704 fixing some details in pxi files

comment:3 Changed 5 years ago by tscrim

This change will produce slightly different output:

-                print "term counting of second summand was wrong!",P2.nterms
+                print("term counting of second summand was wrong!", P2.nterms)

IMO, the easiest way to fix this would be

print("term counting of second summand was wrong!" + str(P2.nterms))

comment:4 Changed 5 years ago by git

  • Commit changed from 719fadf543c94a63fa6b18847b6b8ab8b8e3a6bd to 9186fded470e0f3080840e4db657b6f556bc1db6

Branch pushed to git repo; I updated commit sha1. New commits:

9186fdetrac 20704, detail

comment:5 Changed 5 years ago by git

  • Commit changed from 9186fded470e0f3080840e4db657b6f556bc1db6 to ae8f984a905a7bc8b646f695d81bf4eac88b5b54

Branch pushed to git repo; I updated commit sha1. New commits:

ae8f984trac 20704 another detail

comment:6 Changed 5 years ago by tscrim

  • Cc days74 added
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:7 Changed 5 years ago by tscrim

  • Cc days74 removed
  • Keywords days74 added

comment:8 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

merge conflict

comment:9 Changed 5 years ago by git

  • Commit changed from ae8f984a905a7bc8b646f695d81bf4eac88b5b54 to 6dc2024e02a52c80aaa07f295f23bdcef660c1a2

Branch pushed to git repo; I updated commit sha1. New commits:

6dc2024Merge branch 'public/20704' into 7.3.b3

comment:10 Changed 5 years ago by chapoton

  • Status changed from needs_work to positive_review

after a trivial merge, I allow myself to put this back to positive review.

comment:11 Changed 5 years ago by vbraun

  • Branch changed from public/20704 to 6dc2024e02a52c80aaa07f295f23bdcef660c1a2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.