Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#20698 closed enhancement (fixed)

Revise initialization of generic algebraic curves

Reported by: gjorgenson Owned by:
Priority: minor Milestone: sage-7.3
Component: algebraic geometry Keywords: gsoc2016
Cc: bhutz, mmarco Merged in:
Authors: Grayson Jorgenson Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: d4eb8d4 (Commits) Commit:
Dependencies: Stopgaps:

Description

Revise the Curve function used for initializing generic algebraic curves to allow passing an ambient space in which to construct the curve. Also modify how the curve function works when passing in a subscheme so the ambient space of that subscheme is used instead of creating a new one.

Additionally, implement curve functions for affine/projective space for initializing curves in those ambient spaces.

Change History (12)

comment:1 Changed 16 months ago by gjorgenson

  • Branch set to u/gjorgenson/ticket/20698

comment:2 Changed 16 months ago by git

  • Commit set to 9cbdab3fdfa24144e1aacdf2b7c29d032f016049

Branch pushed to git repo; I updated commit sha1. New commits:

9cbdab320698: revised initialization of generic curves.

comment:3 Changed 16 months ago by gjorgenson

  • Status changed from new to needs_review

comment:4 Changed 16 months ago by bhutz

  • Reviewers set to Ben Hutz
  • Status changed from needs_review to needs_work

Just a couple things here:

In the docs

  • doc build error
OSError: [plane_cur] /home/ben/sage/sage-dev/local/lib/python2.7/site-packages/sage/schemes/plane_curves/constructor.py:docstring of sage.schemes.plane_curves.constructor.Curve:16: ERROR: Unexpected indentation.
  • also variables names should be in double quote, single quote are for math type setting

also some issues with the error messsages

  • Your raise is failing
    A.<x,y,z> = ProjectiveSpace(QQ,2)
    X=A.subscheme([x^3 + y^3 + z^3,x-y])
    C = Curve(X);C
    
  • the line wrap messed up the spacing
A.<x,y,z> = AffineSpace(QQ,3)
A2.<u,v,w,t>=AffineSpace(QQ,4)
C = Curve(x^3 + y^3 + z^3,A2);C

I didn't encounter any functionality issues.

comment:5 Changed 16 months ago by git

  • Commit changed from 9cbdab3fdfa24144e1aacdf2b7c29d032f016049 to b718afabfb2e2233c67aca3ba92cb0150c28e100

Branch pushed to git repo; I updated commit sha1. New commits:

b718afa20698: documentation and error formatting fixes.

comment:6 Changed 16 months ago by gjorgenson

  • Status changed from needs_work to needs_review

Thanks, the issues should be resolved now.

comment:7 Changed 16 months ago by bhutz

  • Status changed from needs_review to needs_work

well, the docs compile, but the formatting isn't right.

  • affine_space/curve
  • projective_space/curve
  • constructor/curve

take a look at the inputs.

comment:8 Changed 16 months ago by git

  • Commit changed from b718afabfb2e2233c67aca3ba92cb0150c28e100 to d4eb8d44b2e878582e19eafae0261b0214704a6c

Branch pushed to git repo; I updated commit sha1. New commits:

d4eb8d420698: documentation spacing fixes.

comment:9 Changed 16 months ago by gjorgenson

  • Status changed from needs_work to needs_review

Oops, sorry. I changed the spacing and indentation, and the docs look better now.

comment:10 Changed 16 months ago by bhutz

  • Status changed from needs_review to positive_review

comment:11 Changed 16 months ago by vbraun

  • Branch changed from u/gjorgenson/ticket/20698 to d4eb8d44b2e878582e19eafae0261b0214704a6c
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 Changed 16 months ago by bhutz

  • Commit d4eb8d44b2e878582e19eafae0261b0214704a6c deleted
  • Keywords gsoc2016 added
Note: See TracTickets for help on using tickets.