Opened 5 years ago
Closed 5 years ago
#20696 closed enhancement (fixed)
Add certificate option to the chordal functions
Reported by:  tara  Owned by:  

Priority:  major  Milestone:  sage7.3 
Component:  matroid theory  Keywords:  
Cc:  Stefan, yomcat  Merged in:  
Authors:  Tara Fife  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  8169d5b (Commits, GitHub, GitLab)  Commit:  8169d5b21177bd57046f3758b016d9a1285d19ee 
Dependencies:  Stopgaps: 
Description
Change History (11)
comment:1 Changed 5 years ago by
 Branch set to public/20696
comment:2 Changed 5 years ago by
 Commit set to e5151995672638410e2da8b74b9f75a6c93628d9
comment:3 Changed 5 years ago by
 Status changed from new to needs_review
comment:4 Changed 5 years ago by
 Status changed from needs_review to needs_work
A few changes I'd like you to do. For the is_circuit_chordal
(and with underscore):
INPUT:  ``C``  a circuit   ``certificate``  (optional) boolean, False if not given. +  ``certificate``  (default: ``False``) boolean OUTPUT: +   Boolean,  and if certificate, ``(x, Ax, Bx)``  a cord ``x`` of ``C``, and circuits ``Ax`` and ``Bx`` showing that ``x`` is a chord, or None if the circuit is not chordal. +  boolean and if certificate is ``True``, also return a tuple + ``(x, Ax, Bx)``, where ``x`` is a chord and ``Ax`` and ``Bx`` + are circuits whose union is ``C`` and ``x``, or ``None`` if + ``C`` is not chordal
For is_chordal
:
 ``k1``  (optional) the integer `k_1`  ``k2``  (optional) the integer `k_2`; if not specified, then this method returns if ``self`` is `k_1`chordal   ``certificate``  (optional) Boolean, False if not specified,  if true, and matroid is not chordal, returns a circuit which is not chordal. +  ``certificate``  (default: ``False``) boolean; if + ``True`` and ``self`` is not chordal, return a circuit + that is not chordal
Also you can specify to cython that certificate
is a boolean by saying it is a bint
.
comment:5 Changed 5 years ago by
 Commit changed from e5151995672638410e2da8b74b9f75a6c93628d9 to e663be3dc4374e7d52dc7f327510a432b02a35f9
Branch pushed to git repo; I updated commit sha1. New commits:
e663be3  Started working, saved so I can change branch

comment:6 Changed 5 years ago by
 Commit changed from e663be3dc4374e7d52dc7f327510a432b02a35f9 to 5b3522e33bcd7555e1e57405e39784103e1644ac
comment:7 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:8 Changed 5 years ago by
 Reviewers set to Travis Scrimshaw
Once you remove the periods at the end of the added doc and add your name to the authors field, you can set a positive review on my behalf.
comment:9 Changed 5 years ago by
 Commit changed from 5b3522e33bcd7555e1e57405e39784103e1644ac to 8169d5b21177bd57046f3758b016d9a1285d19ee
Branch pushed to git repo; I updated commit sha1. New commits:
8169d5b  Deleted some periods

comment:10 Changed 5 years ago by
 Status changed from needs_review to positive_review
I took the freedom to do Travis' suggestions, so I set it to Positive Review.
New commits:
8169d5b  Deleted some periods

comment:11 Changed 5 years ago by
 Branch changed from public/20696 to 8169d5b21177bd57046f3758b016d9a1285d19ee
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
removed doctest