Opened 2 years ago

Closed 7 months ago

#20695 closed enhancement (fixed)

Deprecate dynamics/interval_exchanges and dynamics/flat_surfaces

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.2
Component: combinatorics Keywords:
Cc: fougeroc, tmonteil, slabbe, slelievre Merged in:
Authors: Vincent Delecroix Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 3e122d1 (Commits) Commit: 3e122d1b2560273b159ecff51873acd589f5707a
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

The ​surface_dynamics package provides much more functionalities (and fixes) than what is currently in Sage. This ticket proposes to deprecate all source code from sage.dynamics.flat_surfaces and sage.dynamics.interval_exchanges (with a message giving pointer to the actual package).

Change History (20)

comment:1 Changed 2 years ago by vdelecroix

  • Cc slelievre added

comment:2 Changed 2 years ago by vdelecroix

  • Description modified (diff)
  • Summary changed from remove interval exchange transformation and flat surfaces from Sage source code to Make an optional package for flatsurf and remove associated Sage source code

comment:3 Changed 2 years ago by vdelecroix

  • Branch set to #20856

comment:4 Changed 2 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch changed from #20856 to u/vdelecroix/20695
  • Dependencies set to #20856

comment:5 Changed 2 years ago by vdelecroix

  • Description modified (diff)

comment:6 Changed 2 years ago by vdelecroix

  • Status changed from new to needs_review

comment:7 Changed 2 years ago by git

  • Commit set to 7a52a7728f58a5a332a3c80caf77dc140dcfecd4

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​7a52a77Trac 20695: deprecate flat surfaces related code

comment:8 Changed 2 years ago by vdelecroix

rebased

comment:9 Changed 2 years ago by vdelecroix

  • Description modified (diff)

comment:10 Changed 22 months ago by slabbe

  • Status changed from needs_review to needs_work

Does not merge cleanly...

Why #20856 is a dependency?

comment:11 Changed 7 months ago by vdelecroix

  • Dependencies #20856 deleted
  • Milestone changed from sage-7.3 to sage-8.2

comment:12 Changed 7 months ago by git

  • Commit changed from 7a52a7728f58a5a332a3c80caf77dc140dcfecd4 to 3e122d1b2560273b159ecff51873acd589f5707a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​3e122d120695: deprecate flat_surfaces and interval_exchanges

comment:13 Changed 7 months ago by vdelecroix

  • Status changed from needs_work to needs_review

comment:14 Changed 7 months ago by vdelecroix

  • Description modified (diff)
  • Summary changed from Make an optional package for flatsurf and remove associated Sage source code to Deprecate dynamics/interval_exchanges and dynamics/flat_surfaces

comment:15 Changed 7 months ago by vdelecroix

  • Description modified (diff)

comment:16 Changed 7 months ago by vdelecroix

Patchbot happy :-) It is a lot of work to rebase. Please review.

comment:17 Changed 7 months ago by slabbe

  • Status changed from needs_review to positive_review

Reading Permutation is deprecated and will be removed from Sage is quite funny but we understand that it is the one in iet that is meant. 

sage: T = iet.IntervalExchangeTransformation(Permutation([3,2,1]), [3,1,2])
....: 
/home/slabbe/GitBox/sage/local/lib/python2.7/site-packages/sage/dynamics/interval_exchanges/constructors.py:985: DeprecationWarning: IntervalExchangeTransformation is deprecated and will be removed from Sage.
You are advised to install the surface_dynamics package via:
    sage -pip install surface_dynamics
If you do not have write access to the Sage installation you can
alternatively do
    sage -pip install surface_dynamics --user
The package surface_dynamics subsumes all flat surface related
computation that are currently available in Sage. See more
information at
    http://www.labri.fr/perso/vdelecro/surface-dynamics/latest/
See http://trac.sagemath.org/20695 for details.
  surface_dynamics_deprecation("IntervalExchangeTransformation")
/home/slabbe/GitBox/sage/local/lib/python2.7/site-packages/sage/dynamics/interval_exchanges/constructors.py:392: DeprecationWarning: Permutation is deprecated and will be removed from Sage.
You are advised to install the surface_dynamics package via:
    sage -pip install surface_dynamics
If you do not have write access to the Sage installation you can
alternatively do
    sage -pip install surface_dynamics --user
The package surface_dynamics subsumes all flat surface related
computation that are currently available in Sage. See more
information at
    http://www.labri.fr/perso/vdelecro/surface-dynamics/latest/
See http://trac.sagemath.org/20695 for details.
  surface_dynamics_deprecation("Permutation")

comment:18 Changed 7 months ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missing

comment:19 Changed 7 months ago by tscrim

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_work to positive_review

comment:20 Changed 7 months ago by vbraun

  • Branch changed from u/vdelecroix/20695 to 3e122d1b2560273b159ecff51873acd589f5707a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.