Opened 2 years ago

Closed 2 years ago

#20689 closed enhancement (fixed)

Add certificate option to has_minor

Reported by: tara Owned by:
Priority: minor Milestone: sage-7.3
Component: matroid theory Keywords:
Cc: Stefan, yomcat Merged in:
Authors: Tara Fife Reviewers: Michael Welsh, Stefan van Zwam
Report Upstream: N/A Work issues:
Branch: e8c5b4e (Commits) Commit: e8c5b4e1fdb1c4708f300d361daee941ef490c33
Dependencies: Stopgaps:

Description (last modified by Stefan)

Add an option to the "has_minor" method of matroids to return a witness in case a minor is found.

Change History (22)

comment:1 Changed 2 years ago by tara

  • Branch set to public/ticket/20689

comment:2 Changed 2 years ago by tara

  • Commit set to ca19af1eabcaa84698633fb8e2f2dcbf23cd32a7
  • Status changed from new to needs_review

New commits:

ca19af1Added the option to get the sets `X` and `Y`, where `N` is `M/X\Y`.

comment:3 Changed 2 years ago by yomcat

  • Status changed from needs_review to needs_work
  • Line 88 of matroid.pyx has been messed up
  • At line 1110, you're missing an enter.
  • Line 3893 has bonus whitespace.
  • As on the is_isomorphic() ticket, you should explicitly call the option in the doctests.

comment:4 Changed 2 years ago by git

  • Commit changed from ca19af1eabcaa84698633fb8e2f2dcbf23cd32a7 to 85a6317e97c5f889736f1677d1afb15901d23810

Branch pushed to git repo; I updated commit sha1. New commits:

85a6317Fixed errors

comment:5 Changed 2 years ago by yomcat

  • Authors changed from Tara to Tara Fife
  • Reviewers set to Michael Welsh

Almost done (I feel like a grumpy old man...)

You've got repeated doctests now.

comment:6 Changed 2 years ago by git

  • Commit changed from 85a6317e97c5f889736f1677d1afb15901d23810 to 6fc388d3bc08caa5625272453d95723ca0e8055d

Branch pushed to git repo; I updated commit sha1. New commits:

6fc388dRemoved repeated doctest

comment:7 Changed 2 years ago by Stefan

Should this ticket be in "needs review"?

comment:8 Changed 2 years ago by Stefan

Documentation needs to be in standard form. So

    - ``certificate`` -- (default: ``False``) If true, blablabla

The double backquotes are for code variables, the single backquotes are for math. Also note the way defaults are reported.

Version 0, edited 2 years ago by Stefan (next)

comment:9 Changed 2 years ago by git

  • Commit changed from 6fc388d3bc08caa5625272453d95723ca0e8055d to 1a33e6340048cb10168d5e061be89e9bd558ac24

Branch pushed to git repo; I updated commit sha1. New commits:

1a33e63Eddited documentation

comment:10 Changed 2 years ago by git

  • Commit changed from 1a33e6340048cb10168d5e061be89e9bd558ac24 to 19826d187f2173348a4f5d3ec2fe9b00f647f8f8

Branch pushed to git repo; I updated commit sha1. New commits:

19826d1Eddited errors in documentation

comment:11 Changed 2 years ago by git

  • Commit changed from 19826d187f2173348a4f5d3ec2fe9b00f647f8f8 to d05d6d24cfde51e83a973e2044394747f260e49c

Branch pushed to git repo; I updated commit sha1. New commits:

0b86a6bEddited documentation
d05d6d2Fixed error in documentation

comment:12 Changed 2 years ago by git

  • Commit changed from d05d6d24cfde51e83a973e2044394747f260e49c to 15131de5207f9d2b9eabc24e6b11e97506cecfc9

Branch pushed to git repo; I updated commit sha1. New commits:

15131deFixed spacing error

comment:13 Changed 2 years ago by git

  • Commit changed from 15131de5207f9d2b9eabc24e6b11e97506cecfc9 to 87533057d70e226d533fce0e853cc8a700c74a40

Branch pushed to git repo; I updated commit sha1. New commits:

8753305Fixed doctest

comment:14 Changed 2 years ago by tara

  • Status changed from needs_work to needs_review

comment:15 Changed 2 years ago by vdelecroix

  • Status changed from needs_review to needs_work

Each ticket needs a proper description (at least a line saying what is the goal). For example, there is no way to guess that all this is about matroids!!

comment:16 Changed 2 years ago by Stefan

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:17 Changed 2 years ago by Stefan

In the clause 'if N is self' you should still return the tuple (X,Y,dic), where X = Y = frozenset() and dic = {x: x for x in self.groundset()}

comment:18 Changed 2 years ago by Stefan

  • Status changed from needs_review to needs_work

comment:19 Changed 2 years ago by git

  • Commit changed from 87533057d70e226d533fce0e853cc8a700c74a40 to e8c5b4e1fdb1c4708f300d361daee941ef490c33

Branch pushed to git repo; I updated commit sha1. New commits:

e8c5b4eFixed return when we test if a matroid has itself as a minor.

comment:20 Changed 2 years ago by tara

  • Status changed from needs_work to needs_review

comment:21 Changed 2 years ago by Stefan

  • Reviewers changed from Michael Welsh to Michael Welsh, Stefan van Zwam
  • Status changed from needs_review to positive_review

I'm happy now

comment:22 Changed 2 years ago by vbraun

  • Branch changed from public/ticket/20689 to e8c5b4e1fdb1c4708f300d361daee941ef490c33
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.