Opened 5 years ago
Closed 8 months ago
#20674 closed enhancement (duplicate)
hyperelliptic_g2_rational_field should wrap pari.genus2red
Reported by: | kedlaya | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | algebraic geometry | Keywords: | hyperelliptic curve, genus 2, reduction |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
In Sage 7.2, the file src/sage/schemes/hyperelliptic_curves/hyperelliptic_g2_finite_field.py
has a class whose entire definition is the following:
import hyperelliptic_g2_generic, hyperelliptic_rational_field class HyperellipticCurve_g2_rational_field( hyperelliptic_g2_generic.HyperellipticCurve_g2_generic, hyperelliptic_rational_field.HyperellipticCurve_rational_field): pass
This appears to be a placeholder awaiting a method calling pari.genus2red
(formerly the separate package genus2reduction
). Let's make that happen!
Update:
- using
pari.genus2red
happened in #15808 - the file
src/sage/schemes/hyperelliptic_curves/hyperelliptic_g2_finite_field.py
was removed in #27633
This ticket thus becomes duplicate/invalid/wontfix
.
Change History (4)
comment:1 Changed 8 months ago by
- Milestone changed from sage-7.3 to sage-duplicate/invalid/wontfix
- Status changed from new to needs_review
comment:2 Changed 8 months ago by
- Status changed from needs_review to positive_review
This ticket actually postdates #15808. However, I can no longer find the class in question; it may have been removed by some other ticket. So for that reason, I agree to declare this a duplicate/wontfix.
comment:4 Changed 8 months ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Seems that was done in #15808.
File
src/sage/interfaces/genus2reduction.py
, lines 13--14 and line 439:Setting as invalid/duplicate/wontfix. To confirm, fill in reviewer field and give positive review.