Opened 6 years ago

Closed 6 years ago

#20631 closed defect (fixed)

Support more variable names in Polynomial_rational_flint

Reported by: pbruin Owned by:
Priority: minor Milestone: sage-7.3
Component: algebra Keywords: galois pari
Cc: jdemeyer Merged in:
Authors: Peter Bruin Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 69365f2 (Commits, GitHub, GitLab) Commit: 69365f201fcddc7b975764189abbd38bd9817519
Dependencies: #20630 Stopgaps:

Status badges

Description (last modified by pbruin)

After #20630, the following no longer crashes, but still raises an error: 

sage: R.<theta> = QQ[]
sage: (theta^2 + 1).galois_group(pari_group=True)
...
PariError: theta already exists with incompatible valence

Several methods in Polynomial_rational_flint() have the same problem. We solve this by using the variable name x instead of the Sage variable name when converting to a PARI polynomial.

Change History (6)

comment:1 Changed 6 years ago by pbruin

  • Dependencies set to #20630
  • Description modified (diff)
  • Summary changed from Support more variable names in Polynomial_rational_flint.galois_group() to Support more variable names in Polynomial_rational_flint

comment:2 Changed 6 years ago by pbruin

  • Branch set to u/pbruin/20631-polynomial_pari
  • Commit set to 2de46503adcdbe99b8bed5d494285ce8fdc69f04
  • Status changed from new to needs_review

comment:3 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

One almost trivial thing: 

-if any (n > 1 for n in F[1]):
+if any(n > 1 for n in F[1]):

since any is a function in Python, not a keyword. Otherwise LGTM.

comment:4 Changed 6 years ago by git

  • Commit changed from 2de46503adcdbe99b8bed5d494285ce8fdc69f04 to 69365f201fcddc7b975764189abbd38bd9817519

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​69365f2Trac 20631: support more variable names in Polynomial_rational_flint

comment:5 Changed 6 years ago by pbruin

  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/pbruin/20631-polynomial_pari to 69365f201fcddc7b975764189abbd38bd9817519
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.