Opened 4 years ago

Closed 4 years ago

#20603 closed enhancement (fixed)

py3 print in misc folder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: jdemeyer, embray Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 9e3e403 (Commits) Commit: 9e3e4030fb616e888146249da5214c2f21f4f3f3
Dependencies: Stopgaps:

Description

another step towards python3 print style, now in the rather large misc folder

Change History (9)

comment:1 Changed 4 years ago by chapoton

  • Branch set to public/20603
  • Cc jdemeyer embray added
  • Commit set to 89994a34a08a1458b7d9ad88d941d4f6e9875ee1
  • Status changed from new to needs_review

New commits:

89994a3python3 print in misc folder

comment:2 Changed 4 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

Why I.sort(); print I and not I.sort(); I? Same with for example print N[len(dir):].

You have usually changed continuation line markers, but not in print(kwds) nor in print(af.fix_to_pos()).

Shouldn't print(" ".join(str(i) for i in f)) be print("".join(str(i) for i in f))? Same in src/sage/misc/misc.py.

I will now compile and test.

comment:3 Changed 4 years ago by jmantysalo

My R is broken, so I got errors from misc/sageinspect.py and misc/nested_class.pyx. Otherwise I could have marked this as positive review. I hope that someone else can compile and test those two files.

Last edited 4 years ago by jmantysalo (previous) (diff)

comment:4 Changed 4 years ago by git

  • Commit changed from 89994a34a08a1458b7d9ad88d941d4f6e9875ee1 to ca115d35409e417664b55c5c33e14f8ea400a363

Branch pushed to git repo; I updated commit sha1. New commits:

ca115d3trac 20603 python print in misc folder, details

comment:5 follow-up: Changed 4 years ago by chapoton

These were real failures, due to a line shift in the code.

Let us wait for the next patchbot report

comment:6 Changed 4 years ago by git

  • Commit changed from ca115d35409e417664b55c5c33e14f8ea400a363 to 9e3e4030fb616e888146249da5214c2f21f4f3f3

Branch pushed to git repo; I updated commit sha1. New commits:

9e3e403trac 20603 details

comment:7 in reply to: ↑ 5 Changed 4 years ago by jmantysalo

Replying to chapoton:

These were real failures, due to a line shift in the code.

The one in misc/nested_class.pyx. But from sageinspect.py I got "RuntimeError?: unable to start r". I am quite sure that your two line change works, but anyways would be nice to have someone else to check those. Might be that I won't do that for following three days.

comment:8 Changed 4 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Got it compiled and tested.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from public/20603 to 9e3e4030fb616e888146249da5214c2f21f4f3f3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.