Opened 6 years ago

Closed 6 years ago

#20596 closed enhancement (fixed)

Upgrade to Cython 0.25.1

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.5
Component: cython Keywords:
Cc: robertwb Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 922fa16 (Commits, GitHub, GitLab) Commit: 922fa162edfa888009b66e2dcf66e5427f303d3f
Dependencies: #21697, #21600 Stopgaps:

Status badges

Change History (35)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/20596

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 60788fd4218490e832ae5c8abf46d89ba6a7b280
  • Description modified (diff)
  • Milestone changed from sage-7.3 to sage-pending
  • Status changed from new to needs_review

New commits:

60788fdWork around Cython bug #879

comment:3 Changed 6 years ago by git

  • Commit changed from 60788fd4218490e832ae5c8abf46d89ba6a7b280 to 51c0bcb32e39a2e75624e0606cc0aead3b1d5ccc

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

51c0bcbWork around Cython bug #879

comment:4 Changed 6 years ago by git

  • Commit changed from 51c0bcb32e39a2e75624e0606cc0aead3b1d5ccc to 766dfb07a3012d4523d1af3d275de19003bcacc3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

766dfb0Work around Cython bug #879

comment:5 Changed 6 years ago by jdemeyer

  • Cc robertwb added
  • Description modified (diff)
  • Summary changed from Work around Cython bug #879 to Work around Cython bug #1433

comment:6 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from Reported upstream. No feedback yet. to N/A
  • Status changed from needs_review to needs_work
  • Summary changed from Work around Cython bug #1433 to Upgrade to Cython 0.25

comment:7 Changed 6 years ago by git

  • Commit changed from 766dfb07a3012d4523d1af3d275de19003bcacc3 to 6e1a932ceae175c3bc84f0990cde8b98b6cb96e8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6e1a932Move directives to cythonize() call

comment:8 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 6 years ago by git

  • Commit changed from 6e1a932ceae175c3bc84f0990cde8b98b6cb96e8 to 699f1f8cb34d702ebde8522c538a51074fdb597f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

699f1f8Move old_style_globals to modules; other directives to cythonize() call

comment:10 Changed 6 years ago by git

  • Commit changed from 699f1f8cb34d702ebde8522c538a51074fdb597f to 42d3e05a07150993f976a0647fd63aa330b76fd5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

42d3e05Move old_style_globals to modules; other directives to cythonize() call

comment:11 Changed 6 years ago by git

  • Commit changed from 42d3e05a07150993f976a0647fd63aa330b76fd5 to 00cd961942d1a11f0e36e06f651fcf1c6a79a60f

Branch pushed to git repo; I updated commit sha1. New commits:

00cd961Fix build of pyzmq with Cython 0.25

comment:12 Changed 6 years ago by git

  • Commit changed from 00cd961942d1a11f0e36e06f651fcf1c6a79a60f to b888466a9f1b1c4d55e1bb71836efa6b29d0b866

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

102482cFix build of pyzmq with Cython 0.25
b888466Move old_style_globals to modules; other directives to cythonize() call

comment:13 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Type changed from defect to enhancement

comment:14 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:15 Changed 6 years ago by git

  • Commit changed from b888466a9f1b1c4d55e1bb71836efa6b29d0b866 to 547424765e2e2e89a6b0154516f351238345abec

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5a55862Fix build of pyzmq with Cython 0.25
85634c2Upgrade Cython to version 0.25
5474247Move old_style_globals to modules; other directives to cythonize() call

comment:16 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:17 Changed 6 years ago by jdemeyer

  • Dependencies set to #21441

comment:18 Changed 6 years ago by git

  • Commit changed from 547424765e2e2e89a6b0154516f351238345abec to fffc8d84da79c74fab949500e31f23d48ac67332

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ccd9442Add a sage-pip-install wrapper for pip which handles uninstallation better.
29957faVarious fixes and simplifications to sage-pip-install
783cd7dRe-install all pip-installed packages
8fd8273Fix various dependencies
a81f0b9Fix build of pyzmq with Cython 0.25
07badbeUpgrade Cython to version 0.25
fffc8d8Move old_style_globals to modules; other directives to cythonize() call

comment:19 Changed 6 years ago by jdemeyer

  • Dependencies changed from #21441 to #21697

comment:20 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:21 Changed 6 years ago by jdemeyer

  • Dependencies changed from #21697 to #21697, #21600

comment:22 Changed 6 years ago by git

  • Commit changed from fffc8d84da79c74fab949500e31f23d48ac67332 to ffbfdb84b76e8878c02e31a65afd6f512c2801f8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

636b22aUpgrade to pyzmq 16.0.0
5ba95edClean up stale installed files in install command
35ecf4bRun cythonize() inside build_ext command
2b5fa98Copy extra files to build directory instead of using data_files
dfcd817extra_files -> sage_build_ext.cythonized_files
3d1cb63Merge commit 'dfcd8177447c7eab491569f08777f585deda93ee' into t/20596/ticket/20596
a78498dUpgrade Cython to version 0.25
ffbfdb8Move old_style_globals to individual modules

comment:23 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:24 Changed 6 years ago by git

  • Commit changed from ffbfdb84b76e8878c02e31a65afd6f512c2801f8 to 6a9474b4bffa3eb8f37ca9baf35fc7bfad57772c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

77eb8e2Move old_style_globals to individual modules
6a9474bUpgrade Cython to version 0.25

comment:25 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Milestone changed from sage-pending to sage-7.5

comment:26 Changed 6 years ago by git

  • Commit changed from 6a9474b4bffa3eb8f37ca9baf35fc7bfad57772c to 990c4821dc2cba6357b858b4d4381d5e8ff262f3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

990c482Upgrade Cython to version 0.25

comment:27 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:28 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:29 follow-up: Changed 6 years ago by fbissey

I have seen 0.25.1 is out to fix some unexpected bugs, do we care?

comment:30 in reply to: ↑ 29 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Upgrade to Cython 0.25 to Upgrade to Cython 0.25.1

Replying to fbissey:

I have seen 0.25.1 is out to fix some unexpected bugs, do we care?

I guess we should care.

comment:31 Changed 6 years ago by git

  • Commit changed from 990c4821dc2cba6357b858b4d4381d5e8ff262f3 to 922fa162edfa888009b66e2dcf66e5427f303d3f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

922fa16Upgrade Cython to version 0.25.1

comment:32 Changed 6 years ago by fbissey

I am ready to put this in positive review unless you have something else to do before putting it back from "need_work" to "need_review".

comment:33 Changed 6 years ago by jdemeyer

  • Reviewers set to François Bissey
  • Status changed from needs_work to needs_review

I guess I need to test Sage again with Cython 0.25.1. That will be not for today.

comment:34 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:35 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20596 to 922fa162edfa888009b66e2dcf66e5427f303d3f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.