Opened 6 years ago

Closed 5 years ago

#20584 closed defect (fixed)

Regular partitions: 1-regular partitions are mishandled on occasion

Reported by: Darij Grinberg Owned by:
Priority: major Milestone: sage-8.2
Component: combinatorics Keywords: partition, regular partition, border case
Cc: Travis Scrimshaw Merged in:
Authors: Travis Scrimshaw Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: 7ba506c (Commits, GitHub, GitLab) Commit: 7ba506c69802fb3a259020d7b0cf41767c5cb248
Dependencies: Stopgaps:

Status badges

Description

1-regular partitions exist (although there is just one of them -- the empty one). Not all of the code behaves well at \ell=1, though; e.g., the iterator runs infinite loops once it's past [].

Change History (7)

comment:1 Changed 5 years ago by Travis Scrimshaw

Authors: Travis Scrimshaw
Branch: public/combinat/fix_1_regular_partitions-20584
Commit: 2f0f912920687460bda5ae5c246dea1981d98fed
Milestone: sage-7.3sage-8.2
Status: newneeds_review

Hey, I finally remembered to fix this. ^^;;


New commits:

2f0f912Better handle 1-regular partitions.

comment:2 Changed 5 years ago by Travis Scrimshaw

Component: PLEASE CHANGEcombinatorics

comment:3 Changed 5 years ago by git

Commit: 2f0f912920687460bda5ae5c246dea1981d98fed7ba506c69802fb3a259020d7b0cf41767c5cb248

Branch pushed to git repo; I updated commit sha1. New commits:

9fb5274Merge branch 'public/combinat/fix_1_regular_partitions-20584' of git://trac.sagemath.org/sage into reg
7ba506cminor corrections

comment:4 Changed 5 years ago by Darij Grinberg

Fixed a couple little things, one of which predated this ticket.

I don't know if there is an established way of guaranteeing that any function/method that takes a regular partition will still work with a 1-regular partition. Barring that, the only criterion are the doctests, right? Everything else LGTM.

Last edited 5 years ago by Darij Grinberg (previous) (diff)

comment:5 in reply to:  4 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Replying to darij:

Fixed a couple little things, one of which predated this ticket.

Thanks.

I don't know if there is an established way of guaranteeing that any function/method that takes a regular partition will still work with a 1-regular partition. Barring that, the only criterion are the doctests, right? Everything else LGTM.

No, I don't think there is such a way other than those functions/methods having explicit checks. This is a degenerate case in terms of my applications (there is not really an [affine] sl1), so I'm not really worried.

comment:6 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis ScrimshawDarij Grinberg

comment:7 Changed 5 years ago by Volker Braun

Branch: public/combinat/fix_1_regular_partitions-205847ba506c69802fb3a259020d7b0cf41767c5cb248
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.