Opened 6 years ago

Closed 6 years ago

#20569 closed defect (fixed)

broken giacpy built in 7.2.rc1

Reported by: Han Frederic Owned by:
Priority: blocker Milestone: sage-7.2
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Frederic Han Reviewers: Thierry Monteil
Report Upstream: N/A Work issues:
Branch: eef8b65 (Commits, GitHub, GitLab) Commit: eef8b65d5cf8432a11ad4212c798a6d69023f5e8
Dependencies: Stopgaps:

Status badges

Description (last modified by Han Frederic)

as reported by mmarco in #20258 giacpy.pyx fail to be cythonized in sage 7.2.rc1

Error compiling Cython file:
------------------------------------------------------------
...
     g=(g*M+gen(<long long>i))
     a=a-(i<<size)

   g=g*gen(<long long>(1<<size))+gen(<long long> a)
   if aneg:
     g=-g
      ^
------------------------------------------------------------

giacpy.pyx:5112:7: Invalid operand type for '-' (gen)
Compiling giacpy.pyx because it changed.
[1/1] Cythonizing giacpy.pyx

Fixing this in giacpy 0.5.6. The tarball to put in upstream/ is avaible at: http://webusers.imj-prg.fr/~frederic.han/xcas/giacpy/sage/giacpy-0.5.6.tar.gz

changes can be seen on the giacpy-sage git: https://gitlab.math.univ-paris-diderot.fr/han/giacpy-sage

Change History (7)

comment:1 Changed 6 years ago by Han Frederic

Description: modified (diff)

comment:2 Changed 6 years ago by Han Frederic

Branch: u/frederichan/20569
Commit: eef8b65d5cf8432a11ad4212c798a6d69023f5e8
Description: modified (diff)

New commits:

eef8b65update giacpy to 0.5.6

comment:3 Changed 6 years ago by Han Frederic

Authors: Frederic Han

comment:4 Changed 6 years ago by Han Frederic

Status: newneeds_review

comment:5 Changed 6 years ago by Thierry Monteil

Priority: majorblocker

comment:6 Changed 6 years ago by Thierry Monteil

Reviewers: Thierry Monteil
Status: needs_reviewpositive_review

Compiles well with the fix, and seems to work.

comment:7 Changed 6 years ago by Volker Braun

Branch: u/frederichan/20569eef8b65d5cf8432a11ad4212c798a6d69023f5e8
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.