Opened 4 years ago

Closed 4 years ago

#20554 closed enhancement (fixed)

Python 3 preparation: Remove implicit tuple parameter unpacking (2)

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: python3 Keywords:
Cc: chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: b23f306 (Commits) Commit: b23f306717cd76c6e8d6970eba85075948a2b007
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

This was supposed to be fixed in #15993 but a lot of new instances came up...

This syntax is deprecated, see PEP 3113:

def add_constraints(self, cons, (args, opts)):
    ...

Similarly for lambda (i,j): ..... In many cases, we can actually replace the lambda function either with a list comprehension (if lambda is used for the map() function for example) or with an ordinary Python function.

Change History (7)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Get rid of tuple parameter unpacking to Python 3 preparation: Remove implicit tuple parameter unpacking (2)

comment:3 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/20554

comment:5 Changed 4 years ago by jdemeyer

  • Cc chapoton added
  • Commit set to b23f306717cd76c6e8d6970eba85075948a2b007
  • Status changed from new to needs_review

New commits:

b23f306Get rid of tuple parameter unpacking

comment:6 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20554 to b23f306717cd76c6e8d6970eba85075948a2b007
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.