Opened 6 years ago

Closed 6 years ago

#20554 closed enhancement (fixed)

Python 3 preparation: Remove implicit tuple parameter unpacking (2)

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.2
Component: python3 Keywords:
Cc: Frédéric Chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: b23f306 (Commits, GitHub, GitLab) Commit: b23f306717cd76c6e8d6970eba85075948a2b007
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

This was supposed to be fixed in #15993 but a lot of new instances came up...

This syntax is deprecated, see PEP 3113:

def add_constraints(self, cons, (args, opts)):
    ...

Similarly for lambda (i,j): ..... In many cases, we can actually replace the lambda function either with a list comprehension (if lambda is used for the map() function for example) or with an ordinary Python function.

Change History (7)

comment:1 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:2 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Get rid of tuple parameter unpackingPython 3 preparation: Remove implicit tuple parameter unpacking (2)

comment:3 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:4 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/20554

comment:5 Changed 6 years ago by Jeroen Demeyer

Cc: Frédéric Chapoton added
Commit: b23f306717cd76c6e8d6970eba85075948a2b007
Status: newneeds_review

New commits:

b23f306Get rid of tuple parameter unpacking

comment:6 Changed 6 years ago by Volker Braun

Reviewers: Volker Braun
Status: needs_reviewpositive_review

comment:7 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/ticket/20554b23f306717cd76c6e8d6970eba85075948a2b007
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.