Opened 6 years ago

Closed 6 years ago

#20547 closed enhancement (fixed)

py3 print in symbolic folder

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 18ba7db (Commits, GitHub, GitLab) Commit: 18ba7db1f6b4734289d43f6c081e8eb298c3b090
Dependencies: Stopgaps:

Status badges


another small step towards python3 print

Change History (5)

comment:1 Changed 6 years ago by Frédéric Chapoton

Branch: public/20547
Commit: 18ba7db1f6b4734289d43f6c081e8eb298c3b090
Status: newneeds_review

New commits:

18ba7dbpython3 print in symbolic

comment:2 Changed 6 years ago by Jori Mäntysalo

Reviewers: Jori Mäntysalo

I can take this one.

comment:3 Changed 6 years ago by Jori Mäntysalo

You can mark this as positive_review if you want.

If you want to obey PEPs strictly, add some spaces after commas; you see them with command

git show | egrep '^\+.+,[^ ]'

What is the reason to convert print "foo: ", x to print("foo: {}".format(x) instead of print("foo:", x)?

comment:4 Changed 6 years ago by Frédéric Chapoton

Status: needs_reviewpositive_review

Thanks a lot for the reviews, Jori.

Pep8 is not the priority now. I prefer to do minimal changes, only about print.

Indeed, this is another solution, at least inside the code. I use either, in no systematic way. But the simple way will not work in the doc as long as we have not switched to py3.

comment:5 Changed 6 years ago by Volker Braun

Branch: public/2054718ba7db1f6b4734289d43f6c081e8eb298c3b090
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.