#20542 closed enhancement (fixed)
Allow choosing between ATLAS and OpenBLAS
| Reported by: | jdemeyer | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-7.2 |
| Component: | build | Keywords: | |
| Cc: | embray, fbissey | Merged in: | |
| Authors: | Jeroen Demeyer | Reviewers: | François Bissey |
| Report Upstream: | N/A | Work issues: | |
| Branch: | df750a3 (Commits, GitHub, GitLab) | Commit: | |
| Dependencies: | #20392 | Stopgaps: |
Status badges
Description
Add a ./configure option --with-blas to choose between ATLAS and OpenBLAS.
Installing both is not supported.
Change History (16)
comment:1 Changed 7 years ago by
| Dependencies: | → #20392 |
|---|
comment:2 Changed 7 years ago by
| Branch: | → u/jdemeyer/allow_choosing_between_atlas_and_openblas |
|---|
comment:3 Changed 7 years ago by
| Commit: | → aacebbabaf6f9b82ffc0b4513e99559ef1408af9 |
|---|
comment:4 Changed 7 years ago by
| Commit: | aacebbabaf6f9b82ffc0b4513e99559ef1408af9 → df750a356e54cd53c311247aa452249e93ff32b3 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| df750a3 | Fix doctests for OpenBLAS
|
comment:5 Changed 7 years ago by
| Status: | new → needs_review |
|---|
comment:6 follow-up: 7 Changed 7 years ago by
The mechanics looks alright but I went to have a few hours to digest it. Since we are not changing the current spkg, things are not as informative as they could be. How do you know from configure --help that
1) --with-blas=atlas (or nothing) allows you to use a system ATLAS via an environment variable. 2) that the same option will give use the accelerate framework on OS X by default (there is a way to force ATLAS build but that's a real expert case).
The first one may qualify as an expert use case where we don't want to make the suggestion in configuration's help message. I think the second one should deserve a mention, one way or another.
comment:7 Changed 7 years ago by
Replying to fbissey:
How do you know from
configure --helpthat1) --with-blas=atlas (or nothing) allows you to use a system ATLAS via an environment variable. 2) that the same option will give use the accelerate framework on OS X by default (there is a way to force ATLAS build but that's a real expert case).
Well, the ATLAS options are documented in http://doc.sagemath.org/html/en/installation/source.html#environment-variables
I agree that it's not very clear, but I was hoping that this ticket could be reviewed anyway with further work for a follow-up ticket.
Ideally we should move some of the configuration logic of the ATLAS spkg either to a generic BLAS meta-package or the top-level configure script. I haven't completely thought out the details of this, but I don't see much point in documenting something which I plan to change soon anyway.
comment:8 Changed 7 years ago by
Also: as long as the default remains ATLAS, old configurations using SAGE_ATLAS... environment variables will continue to work.
comment:9 follow-up: 10 Changed 7 years ago by
| Reviewers: | → François Bissey |
|---|---|
| Status: | needs_review → positive_review |
OK, deal. Sending to the bots.
comment:10 Changed 7 years ago by
Replying to fbissey:
OK, deal. Sending to the bots.
Well, the bots won't test OpenBLAS, so I don't expect problems.
comment:11 Changed 7 years ago by
| Branch: | u/jdemeyer/allow_choosing_between_atlas_and_openblas → df750a356e54cd53c311247aa452249e93ff32b3 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
comment:12 Changed 7 years ago by
| Commit: | df750a356e54cd53c311247aa452249e93ff32b3 |
|---|
Ideally we should move some of the configuration logic of the ATLAS spkg either to a generic BLAS meta-package or the top-level configure script.
This is partly why I suggested the former, earlier. But I agree further work could be in a follow-up. This is a good move in the right direction.
comment:13 follow-up: 14 Changed 6 years ago by
With all respect, this ticket should have been changing that docs, too. Do you expect that people would read configure source just to figure out how to switch between Atlas and OpenBlas? E.g., how does one build with Atlas?!
Besides, with-blas is misleading. Surely, in both bases BLAS is used, just different ones...
comment:14 follow-up: 15 Changed 6 years ago by
Replying to dimpase:
With all respect, this ticket should have been changing that docs, too. Do you expect that people would read configure source just to figure out how to switch between Atlas and OpenBlas? E.g., how does one build with Atlas?!
No, but I would expect them to read ./configure --help. If the help docs are broken then yeah I agree.
comment:15 Changed 6 years ago by
Replying to embray:
Replying to dimpase:
With all respect, this ticket should have been changing that docs, too. Do you expect that people would read configure source just to figure out how to switch between Atlas and OpenBlas? E.g., how does one build with Atlas?!
No, but I would expect them to read
./configure --help. If the help docs are broken then yeah I agree.
./configure ?
./configure is not mentioned in the official manual.
cf http://doc.sagemath.org/html/en/installation/source.html#step-by-step-installation-procedure
or your locally built manual for the latest 7.5.beta
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
Merge tag '7.2.beta6' into t/20542/allow_choosing_between_atlas_and_openblasAllow choosing between ATLAS and OpenBLAS