Opened 7 years ago
Closed 7 years ago
#20541 closed enhancement (fixed)
py3 print in matrix folder
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.2 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Jori Mäntysalo |
Report Upstream: | N/A | Work issues: | |
Branch: | 7c12326 (Commits, GitHub, GitLab) | Commit: | 7c123263f2a5a4ac052559c53b1090fa3669bc92 |
Dependencies: | Stopgaps: |
Description
another step towards python3 print
Change History (7)
comment:1 Changed 7 years ago by
Branch: | → public/20541 |
---|---|
Commit: | → fd35ef0fcc09060a0fbd945a50e243631f06ceba |
Status: | new → needs_review |
comment:2 Changed 7 years ago by
Reviewers: | → Jori Mäntysalo |
---|
Seems to be OK. I'll compile and check before setting positive review.
comment:3 Changed 7 years ago by
Status: | needs_review → needs_work |
---|
Not OK: In matrix_modn_dense_template.pxi
first TEST block has the line
print('{} x {} = {}'.format(v, m, v * m)
i.e. missing a closing parenthesis.
comment:4 Changed 7 years ago by
Commit: | fd35ef0fcc09060a0fbd945a50e243631f06ceba → 7c123263f2a5a4ac052559c53b1090fa3669bc92 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
7c12326 | python 3 print for matrices, detail
|
comment:7 Changed 7 years ago by
Branch: | public/20541 → 7c123263f2a5a4ac052559c53b1090fa3669bc92 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
python3 print in matrices folder