Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#20533 closed enhancement (fixed)

Change again integer divisions from / to // in combinat

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: python3 Keywords: division
Cc: jdemeyer, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b44fb64 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges


ticket split off of #18659

Change History (5)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/20533
  • Cc jdemeyer tscrim added
  • Commit set to b44fb643c252d5e362089352e1326f1f95091c27
  • Status changed from new to needs_review

New commits:

4c5457dhandling some more future divisions
f9f15bbsome details
3527969wundo wrong change in crystals
aaf1a12another try for division in kirillov reshetikhin crystals
b5ab223trac 18659 better corrections in rst files
8de2be4Fixing division in rigged configurations.
63b3f33Merge branch 'u/tscrim/18659' into 7.2.b6
b44fb64splitting off by keeping only combinat things

comment:2 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Up to the patchbot coming back green, this is a positive review.

comment:3 Changed 5 years ago by vbraun

  • Branch changed from public/20533 to b44fb643c252d5e362089352e1326f1f95091c27
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 5 years ago by chapoton

  • Commit b44fb643c252d5e362089352e1326f1f95091c27 deleted

It seems that this has been meanwhile undone by #18659, created before but merged after !!!! Incredible !

comment:5 Changed 3 years ago by embray

  • Keywords division added
Note: See TracTickets for help on using tickets.