Opened 6 years ago

Closed 6 years ago

#20527 closed enhancement (fixed)

py3 print in calculus and coding

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.3
Component: python3 Keywords:
Cc: vdelecroix, tscrim, jdemeyer, embray Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0024111 (Commits, GitHub, GitLab) Commit: 0024111a865dac31e06cef7e579981d14dcdd390
Dependencies: Stopgaps:

Status badges

Description

another small step towards python3 print

Change History (13)

comment:1 Changed 6 years ago by chapoton

  • Branch set to public/20527
  • Commit set to 058e63d63120a7d36bae648275b4bcc8c00be597
  • Status changed from new to needs_review

New commits:

058e63dpy3 print in coding and calculus

comment:2 Changed 6 years ago by chapoton

  • Cc vdelecroix tscrim jdemeyer embray added

comment:3 Changed 6 years ago by jdemeyer

I would much rather prefer to just remove the commented-out # print calls. Reviewing commented-out code seems pointless.

comment:4 Changed 6 years ago by git

  • Commit changed from 058e63d63120a7d36bae648275b4bcc8c00be597 to 5f985a127ee23be6fa4cfcccb070e53cdc02c84c

Branch pushed to git repo; I updated commit sha1. New commits:

5f985a1trac 20257 removal of many commented prints

comment:5 Changed 6 years ago by chapoton

yes, indeed. Done.

comment:6 Changed 6 years ago by jdemeyer

Same for print calls in if False: blocks...

comment:7 Changed 6 years ago by git

  • Commit changed from 5f985a127ee23be6fa4cfcccb070e53cdc02c84c to 0024111a865dac31e06cef7e579981d14dcdd390

Branch pushed to git repo; I updated commit sha1. New commits:

0024111trac #20527 removing code inside "if False"

comment:8 Changed 6 years ago by chapoton

hmm, I removed completely the content of the if False blocks, but maybe this is too intrusive ?

comment:9 Changed 6 years ago by chapoton

ping ?

comment:10 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-7.2 to sage-7.3
  • Reviewers set to Jeroen Demeyer

comment:11 Changed 6 years ago by chapoton

re-ping ?

comment:12 Changed 6 years ago by tscrim

  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Travis Scrimshaw
  • Status changed from needs_review to positive_review

I think it is okay.

comment:13 Changed 6 years ago by vbraun

  • Branch changed from public/20527 to 0024111a865dac31e06cef7e579981d14dcdd390
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.