Changes between Initial Version and Version 1 of Ticket #20523, comment 55


Ignore:
Timestamp:
02/20/17 20:10:39 (5 years ago)
Author:
charpent
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20523, comment 55

    initial v1  
    77> (PS: While I agree with Dima that it is a very good practice to merge in your dependencies, it is not strictly necessary.)
    88
    9 I tried to follow the guidelines of the Developer's guide thai aim to break a large issue in smaller, independent ones. Merging one ticket into another implies review of the same patches *twice*.
     9I tried to follow the guidelines of the Developer's guide that aim to break a large issue in smaller, independent ones. Merging one ticket into another implies review of the same patches *twice*.
    1010
    11 I didn't see the point but understood the aim of consistency. Now, I am lost. Do you really want two reviews of the same code ?
     11I didn't see Dima's point but understood the aim of consistency. Now, I am lost. Do you really want two reviews of the same code ?
    1212
    13 I'll wait for your answer before cancelling my invalidation requests. After all, these tickets were ready for reviews only four and three months ago...
     13I'll wait for your answer before cancelling my invalidation requests and re-adding the dependencies. After all, these tickets were ready for reviews only four and three months ago...