Opened 3 years ago

Closed 3 years ago

#20521 closed enhancement (fixed)

Left and right actions for real reflection groups, actions on the reflection repr and its dual

Reported by: stumpc5 Owned by:
Priority: major Milestone: sage-7.2
Component: combinatorics Keywords:
Cc: tscrim, chapoton, nthiery, vripoll Merged in:
Authors: Christian Stump Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e71529e (Commits) Commit: e71529efca88b4fa8c3fb7b67924333fd75041fb
Dependencies: Stopgaps:

Description

This ticket implements left and right actions for real reflection groups and actions on the reflection representation and its dual for all complex reflection groups.

Change History (10)

comment:1 Changed 3 years ago by stumpc5

  • Branch set to u/stumpc5/20521

comment:2 Changed 3 years ago by git

  • Commit set to b5a56ccd0c240d24950e9e969511ac55b3fa1910

Branch pushed to git repo; I updated commit sha1. New commits:

b5a56ccadded indirect doctest flags

comment:3 Changed 3 years ago by stumpc5

  • Status changed from new to needs_review

comment:4 Changed 3 years ago by tscrim

  • Branch changed from u/stumpc5/20521 to public/combinat/actions_reflection_groups-20521
  • Commit changed from b5a56ccd0c240d24950e9e969511ac55b3fa1910 to eaa9da0dc1ca6332fda0569dfcc698c4fde0a669
  • Reviewers set to Travis Scrimshaw

I have made some reviewer changes, but I was wondering if you could explain the TODO note and why we can't do that here.


New commits:

eaa9da0Some minor reviewer changes.

comment:5 Changed 3 years ago by stumpc5

In real types, you see that I don't create the matrix and do the multiplication directly. This is the factor 10 speedup. For crg's I first wanted to properly get the left/right and primal/dual space actions correctly before considering to do the multiplication directly. But since the simple roots do not form a basis, I would need to also multiply with the base change matrix. So I removed the todo note...

comment:6 Changed 3 years ago by git

  • Commit changed from eaa9da0dc1ca6332fda0569dfcc698c4fde0a669 to e71529efca88b4fa8c3fb7b67924333fd75041fb

Branch pushed to git repo; I updated commit sha1. New commits:

e71529eminor improvement of as_matrix + removal of todo note

comment:7 Changed 3 years ago by tscrim

LGTM. Thanks. If you're happy with my changes, then you can put your name as the author and set a positive review.

comment:8 Changed 3 years ago by stumpc5

  • Authors set to Christian Stump
  • Status changed from needs_review to positive_review

comment:9 Changed 3 years ago by stumpc5

Thanks, Travis, for the quick review!

comment:10 Changed 3 years ago by vbraun

  • Branch changed from public/combinat/actions_reflection_groups-20521 to e71529efca88b4fa8c3fb7b67924333fd75041fb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.