Opened 4 years ago
Closed 4 years ago
#20521 closed enhancement (fixed)
Left and right actions for real reflection groups, actions on the reflection repr and its dual
Reported by:  stumpc5  Owned by:  

Priority:  major  Milestone:  sage7.2 
Component:  combinatorics  Keywords:  
Cc:  tscrim, chapoton, nthiery, vripoll  Merged in:  
Authors:  Christian Stump  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  e71529e (Commits)  Commit:  e71529efca88b4fa8c3fb7b67924333fd75041fb 
Dependencies:  Stopgaps: 
Description
This ticket implements left and right actions for real reflection groups and actions on the reflection representation and its dual for all complex reflection groups.
Change History (10)
comment:1 Changed 4 years ago by
 Branch set to u/stumpc5/20521
comment:2 Changed 4 years ago by
 Commit set to b5a56ccd0c240d24950e9e969511ac55b3fa1910
comment:3 Changed 4 years ago by
 Status changed from new to needs_review
comment:4 Changed 4 years ago by
 Branch changed from u/stumpc5/20521 to public/combinat/actions_reflection_groups20521
 Commit changed from b5a56ccd0c240d24950e9e969511ac55b3fa1910 to eaa9da0dc1ca6332fda0569dfcc698c4fde0a669
 Reviewers set to Travis Scrimshaw
I have made some reviewer changes, but I was wondering if you could explain the TODO
note and why we can't do that here.
New commits:
eaa9da0  Some minor reviewer changes.

comment:5 Changed 4 years ago by
In real types, you see that I don't create the matrix and do the multiplication directly. This is the factor 10 speedup. For crg's I first wanted to properly get the left/right and primal/dual space actions correctly before considering to do the multiplication directly. But since the simple roots do not form a basis, I would need to also multiply with the base change matrix. So I removed the todo note...
comment:6 Changed 4 years ago by
 Commit changed from eaa9da0dc1ca6332fda0569dfcc698c4fde0a669 to e71529efca88b4fa8c3fb7b67924333fd75041fb
Branch pushed to git repo; I updated commit sha1. New commits:
e71529e  minor improvement of as_matrix + removal of todo note

comment:7 Changed 4 years ago by
LGTM. Thanks. If you're happy with my changes, then you can put your name as the author and set a positive review.
comment:8 Changed 4 years ago by
 Status changed from needs_review to positive_review
comment:9 Changed 4 years ago by
Thanks, Travis, for the quick review!
comment:10 Changed 4 years ago by
 Branch changed from public/combinat/actions_reflection_groups20521 to e71529efca88b4fa8c3fb7b67924333fd75041fb
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
added indirect doctest flags