Opened 6 years ago

Closed 6 years ago

#20518 closed defect (fixed)

print to py3 in sat and stats

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8fc2a4e (Commits, GitHub, GitLab) Commit: 8fc2a4ead966f6b3149562efc1d1c863464aa9aa
Dependencies: Stopgaps:

Status badges

Description

another small step of conversion of print to py3

Change History (8)

comment:1 Changed 6 years ago by chapoton

  • Branch set to public/20518
  • Commit set to 8eb656b151f178c9e7a37a19499f66265ceec5e4
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by chapoton

  • Summary changed from print ot py3 in sat and stats to print to py3 in sat and stats

comment:3 Changed 6 years ago by tscrim

  • Status changed from needs_review to needs_work

Because the python3 print function is not used in the doctests, you have 3 doctest failures due to syntax errors.

comment:4 Changed 6 years ago by git

  • Commit changed from 8eb656b151f178c9e7a37a19499f66265ceec5e4 to d00038b3a3164c9d4b69b3e3e2a2ccc066142181

Branch pushed to git repo; I updated commit sha1. New commits:

d00038btrac #20518 getting rid of print for 3 doctests

comment:5 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

should be ok now

comment:6 Changed 6 years ago by git

  • Commit changed from d00038b3a3164c9d4b69b3e3e2a2ccc066142181 to 8fc2a4ead966f6b3149562efc1d1c863464aa9aa

Branch pushed to git repo; I updated commit sha1. New commits:

8fc2a4efixing two doctests

comment:7 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:8 Changed 6 years ago by vbraun

  • Branch changed from public/20518 to 8fc2a4ead966f6b3149562efc1d1c863464aa9aa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.