Opened 3 years ago

Closed 3 years ago

#20513 closed defect (fixed)

bug with cyclotomic fields embeddings and coercions

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-7.2
Component: number fields Keywords:
Cc: cremona Merged in:
Authors: Vincent Delecroix Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 1b5051f (Commits) Commit: 1b5051f4bb774b39bfc3513fe35446da8944cd13
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

sage: K60.<zeta60> = CyclotomicField(60)
sage: K30.<zeta30> = CyclotomicField(30, embedding=zeta60**2)
sage: K15.<zeta15> = CyclotomicField(15, embedding=zeta30**2)
sage: K5.<zeta5> = CyclotomicField(5, embedding=zeta15**3)
sage: zeta5 * zeta60
# BOOM #

see: https://groups.google.com/forum/#!topic/sage-support/J4rLkHUNU1E

Change History (9)

comment:1 Changed 3 years ago by vdelecroix

  • Branch set to u/vdelecroix/20513
  • Commit set to c96139adf1ff7114315c312b7a2c97cd0e76940e
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

8d8602fTrac 20400: conversion rational in NF -> QQbar
c96139aTrac 20513: fix cyclotomic field embeddings

comment:2 Changed 3 years ago by git

  • Commit changed from c96139adf1ff7114315c312b7a2c97cd0e76940e to 7ccc96265c1272d7953258135bfbe7eb7eba1596

Branch pushed to git repo; I updated commit sha1. New commits:

7ccc962Trac 20513: doctest

comment:3 Changed 3 years ago by git

  • Commit changed from 7ccc96265c1272d7953258135bfbe7eb7eba1596 to 1b5051f4bb774b39bfc3513fe35446da8944cd13

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6992729Trac 20513: fix cyclotomic field embeddings
1b5051fTrac 20513: doctest

comment:4 Changed 3 years ago by cremona

The code looks good. I am building the branch to test now.

comment:5 Changed 3 years ago by kedlaya

Maybe add the example from #20261 as another doctest?

comment:6 Changed 3 years ago by vdelecroix

#20261 is not fixed by this ticket.

comment:7 Changed 3 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:8 Changed 3 years ago by vdelecroix

Thanks Volker!

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/vdelecroix/20513 to 1b5051f4bb774b39bfc3513fe35446da8944cd13
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.