Changes between Version 2 and Version 8 of Ticket #20495


Ignore:
Timestamp:
08/30/16 12:53:42 (5 years ago)
Author:
jmantysalo
Comment:

How this looks? I think that this should still simplified, so that RandomLattice will contain only the parameters check and the logic to choise right function to do the job.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20495

    • Property Status changed from needs_review to needs_work
    • Property Commit changed from 60eff31087c3784f997ae2f49bd5150e676fad85 to cd7104619519cee19b5c741888870d96d53f6ed2
  • Ticket #20495 – Description

    v2 v8  
    11This patch will add a function to generate a random lattice with given number of elements.
    22
    3 Currently only "dismantlable" is implemented as a property. Is this a good desing from user perspective? I hope to later add for example "modular", but of course most combinations will always just raise NotImplemented, as there are at least dozens of meaningful combinations that should be coded one by one.
     3Currently only "dismantlable" and "planar" are implemented as a property. Is this a good desing from user perspective? I hope to later add for example "modular", but of course most combinations will always just raise NotImplemented, as there are at least dozens of meaningful combinations that should be coded one by one.
    44
    55I am not satisfied of this code, but at least it works and is quite fast.