Opened 6 years ago

Closed 6 years ago

#20485 closed defect (fixed)

The dim() of a quadratic form should be a Sage Integer

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: quadratic forms Keywords:
Cc: chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 51ff3d7 (Commits, GitHub, GitLab) Commit: 51ff3d78c7eba2a90e0cd27f875d0efaa3705b62
Dependencies: Stopgaps:

Status badges


Change History (4)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/the_dim___of_a_quadratic_form_should_be_a_sage_integer

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 51ff3d78c7eba2a90e0cd27f875d0efaa3705b62
  • Status changed from new to needs_review

New commits:

51ff3d7Return a Sage Integer for dim()

comment:3 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me.

comment:4 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/the_dim___of_a_quadratic_form_should_be_a_sage_integer to 51ff3d78c7eba2a90e0cd27f875d0efaa3705b62
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.