Opened 6 years ago
Closed 3 years ago
#20484 closed enhancement (invalid)
Use the cythonized versions of has_descent, first_descent, descents for reflection groups
Reported by:  stumpc5  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  combinatorics  Keywords:  
Cc:  tscrim, chapoton, nthiery, vripoll  Merged in:  
Authors:  Reviewers:  Christian Stump  
Report Upstream:  N/A  Work issues:  
Branch:  Commit:  
Dependencies:  Stopgaps: 
Change History (10)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
And also:
sage:W = ReflectionGroup(['A',7]) sage: c = W.index_set(); Q = c + tuple(W.w0.coxeter_sorting_word(c)) sage: %prun SC = SubwordComplex(Q,W.w0,algorithm="greedy") 4605779 function calls (4605355 primitive calls) in 8.236 seconds Ordered by: internal time ncalls tottime percall cumtime percall filename:lineno(function) 560742 1.870 0.000 4.946 0.000 reflection_group_real.py:790(has_descent) 560742 1.363 0.000 2.774 0.000 coxeter_groups.py:717(has_right_descent) 560770 1.321 0.000 1.412 0.000 reflection_group_real.py:771(has_left_descent) 178698 0.744 0.000 5.690 0.000 coxeter_groups.py:763(first_descent)
comment:3 Changed 5 years ago by
 Branch set to public/20484
 Commit set to c9bdf03eb93aad748849c366229a2d4e610c90ce
I just made a branch. Not having chevie, I have no way to tell if this is faster than before.
New commits:
c9bdf03  trac 20484 first try

comment:4 Changed 4 years ago by
This was (mostly) taken care of indirectly on #22600.
comment:5 Changed 4 years ago by
 Milestone changed from sage7.2 to sageduplicate/invalid/wontfix
 Status changed from new to needs_review
comment:6 Changed 4 years ago by
 Reviewers set to Christian Stump
 Status changed from needs_review to positive_review
Christian over my laptop concurs.
comment:7 Changed 4 years ago by
Sind Sie in Berlin ?
Would you guys have a little time to look at the failures in the python3docbuild that are related to crystals ? See there for the log (search for Error:
and AttributeError: 'RootSystem' object has no attribute 'dual'
)
comment:8 Changed 4 years ago by
the branch is red..
comment:9 Changed 4 years ago by
 Branch public/20484 deleted
 Commit c9bdf03eb93aad748849c366229a2d4e610c90ce deleted
See comment:4
comment:10 Changed 3 years ago by
 Resolution set to invalid
 Status changed from positive_review to closed
Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.
Note: See
TracTickets for help on using
tickets.
For the record: subword complexes would appreciate fast
apply_simple_reflection_left
andhas_left_descent
, see