Opened 5 years ago

Closed 5 years ago

#20483 closed defect (fixed)

some more future division in quadratic_form

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: quadratic forms Keywords: python3
Cc: tscrim, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 01c31fb (Commits, GitHub, GitLab) Commit: 01c31fba5ecd0a3849b823f4756c26877af9ca45
Dependencies: #20485 Stopgaps:

Status badges

Description

as in #20471, trying to prepare for python3 by correcting some divisions.

plus also the same kind of thing in a custom matrix ascii art in numerical

Change History (18)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/20483
  • Cc tscrim jdemeyer added
  • Commit set to 43afbe1df1cbd2d52450b859c8f85d0781e12edd
  • Status changed from new to needs_review

New commits:

43afbe1more work on future of division in py3

comment:2 Changed 5 years ago by jdemeyer

I slightly prefer QQ((1,2)) over QQ.one()/2.

comment:3 Changed 5 years ago by git

  • Commit changed from 43afbe1df1cbd2d52450b859c8f85d0781e12edd to 019386abb6b7067f762b08dae7ab844613242af4

Branch pushed to git repo; I updated commit sha1. New commits:

d195c1bMerge branch 'u/chapoton/20483' into 7.2.b5
019386atrac 20483 using QQ((1,2))

comment:4 Changed 5 years ago by jdemeyer

  • Dependencies set to #20485
  • Status changed from needs_review to needs_work

I suggest to remove the change to the dim() call and use #20485 instead.

comment:5 Changed 5 years ago by jdemeyer

Another detail: better write QQ((-1, 2)) instead of -QQ((1, 2)) and add a doctest for zeta__exact(0).

Last edited 5 years ago by jdemeyer (previous) (diff)

comment:6 Changed 5 years ago by git

  • Commit changed from 019386abb6b7067f762b08dae7ab844613242af4 to ecd2139a41ace13330e214b23a21d14a43a0b96a

Branch pushed to git repo; I updated commit sha1. New commits:

ecd2139assuming now that self.dim is a sage integer (done in another ticket)

comment:7 Changed 5 years ago by git

  • Commit changed from ecd2139a41ace13330e214b23a21d14a43a0b96a to 035fdf8d4521974553255a0c8cdccf20d447ac42

Branch pushed to git repo; I updated commit sha1. New commits:

035fdf8adding doctest for zeta_exact(0)

comment:8 Changed 5 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:9 Changed 5 years ago by chapoton

ping ?

comment:10 Changed 5 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_work

I see patchbot failures...

comment:11 Changed 5 years ago by jdemeyer

Hang on, I'm working on a fix.

comment:12 follow-up: Changed 5 years ago by chapoton

patchbot failures are coming from the dependency being not integrated in the branch

comment:13 in reply to: ↑ 12 Changed 5 years ago by jdemeyer

Replying to chapoton:

patchbot failures are coming from the dependency being not integrated in the branch

That's not completely true. Some are, but some are really genuine failures.

comment:14 Changed 5 years ago by jdemeyer

  • Branch changed from u/chapoton/20483 to u/jdemeyer/20483

comment:15 Changed 5 years ago by jdemeyer

  • Commit changed from 035fdf8d4521974553255a0c8cdccf20d447ac42 to 01c31fba5ecd0a3849b823f4756c26877af9ca45

New commits:

51ff3d7Return a Sage Integer for dim()
0bbc31amore work on future of division in py3
72c2889trac 20483 using QQ((1,2))
ddba939assuming now that self.dim is a sage integer (done in another ticket)
dd38abcadding doctest for zeta_exact(0)
01c31fbFix gamma__exact

comment:16 Changed 5 years ago by jdemeyer

Rebased on top of #20485 and added one commit. If you're happy with this commit, you can set it to positive_review.

comment:17 Changed 5 years ago by chapoton

  • Status changed from needs_work to positive_review

ok, thanks

comment:18 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/20483 to 01c31fba5ecd0a3849b823f4756c26877af9ca45
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.