#20482 closed enhancement (fixed)
remove unicode dashes from the doc
Reported by:  chapoton  Owned by:  

Priority:  trivial  Milestone:  sage7.2 
Component:  documentation  Keywords:  beginner 
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Jori Mäntysalo 
Report Upstream:  N/A  Work issues:  
Branch:  2e8a089 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
At some point in the past, these little dashes were posing problems for docbuilding. Obviously, the few ones that are still there do no pose any such problem, and they are there since some time already.
Either we can do that as a little docsanitizing (even if maybe not really useful) or we can close as invalid.
Change History (24)
comment:1 Changed 5 years ago by
 Branch set to public/20482
 Commit set to ec24c9fed266f2aa908df8168950776138b83e47
 Status changed from new to needs_review
comment:3 Changed 5 years ago by
Well, I must admit that I am not so sure. At some point in the past, these little dashes were posing problems for docbuilding. Obviously, the few ones that are still there do no pose any such problem, and they are there since some time already.
Either we can do that as a little docsanitizing (even if maybe not really useful) or we can close as invalid.
comment:4 Changed 5 years ago by
 Description modified (diff)
 Status changed from needs_info to needs_review
comment:5 Changed 5 years ago by
Is there any reason to not do this?
I guess these will give strange errors when somebody copypaste text from manual to some text processor. Maybe something like "Can not save character  in this encoding" or like. It is much more confusing than, say, "Can not save character ä in this encoding".
comment:6 followup: ↓ 7 Changed 5 years ago by
I think there is no reason not to do that. So if you feel like giving a positive review, please do so.
comment:7 in reply to: ↑ 6 Changed 5 years ago by
 Reviewers set to Jori Mäntysalo
Replying to chapoton:
I think there is no reason not to do that. So if you feel like giving a positive review, please do so.
OK. Compiling and testing.
comment:9 Changed 5 years ago by
Backslash abbreviated first names: .. [Dejean] F. Dejean
should be .. [Dejean] \F. Dejean
.
comment:10 Changed 5 years ago by
 Status changed from positive_review to needs_work
And this obviously conflicts with #20496 :(
comment:11 Changed 5 years ago by
I think you should either rebase on #20496 or add the backslashes where needed in the references that you change.
comment:12 followup: ↓ 13 Changed 5 years ago by
Come on, Jeroen, this ticket was positive reviewed, whereas #20496 is not yet. Why should you decide that this ticket must be rebased and not the other way round ?
This being said, I am nevertheless willing to cooperate.
comment:13 in reply to: ↑ 12 Changed 5 years ago by
Replying to chapoton:
Why should you decide that this ticket must be rebased and not the other way round ?
Please read 11 again: I think you should either rebase on #20496 or add the backslashes where needed in the references that you change.
I just think that will make the merge easier, regardless of which ticket gets merged first.
comment:14 Changed 5 years ago by
 Commit changed from ec24c9fed266f2aa908df8168950776138b83e47 to c269340209a2e6ad4abf07291431cb285e4fb65e
comment:15 Changed 5 years ago by
is this ok for you now ?
comment:16 Changed 5 years ago by
I think you forgot this:
.. [Ser1985] C. Series. The geometry of Markoff numbers. The Mathematical  Intelligencer, 7(3):20–29, 1985. + Intelligencer, 7(3):2029, 1985. .. [SU2009] J. Smillie and C. Ulcigrai. Symbolic coding for linear trajectories in the regular octagon, :arxiv:`0905.0871`, 2009.
Can you fix both the above references?
comment:17 Changed 5 years ago by
 Commit changed from c269340209a2e6ad4abf07291431cb285e4fb65e to 957d06596b2fe1ab91f0409334ca3d194c2c5b52
Branch pushed to git repo; I updated commit sha1. New commits:
957d065  trac 20482 forgot two escape of initials

comment:18 Changed 5 years ago by
 Status changed from needs_work to positive_review
comment:19 followup: ↓ 24 Changed 5 years ago by
 Status changed from positive_review to needs_work
merge conflict
comment:20 Changed 5 years ago by
 Commit changed from 957d06596b2fe1ab91f0409334ca3d194c2c5b52 to 2e8a0898fd108cb82ad5a3af18512b2018aaf786
Branch pushed to git repo; I updated commit sha1. New commits:
2e8a089  Merge branch 'public/20482' into 7.2.b6

comment:21 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:22 Changed 5 years ago by
 Status changed from needs_review to positive_review
ok, bots are green, I put this back to positive review
comment:23 Changed 5 years ago by
 Branch changed from public/20482 to 2e8a0898fd108cb82ad5a3af18512b2018aaf786
 Resolution set to fixed
 Status changed from positive_review to closed
comment:24 in reply to: ↑ 19 Changed 5 years ago by
 Commit 2e8a0898fd108cb82ad5a3af18512b2018aaf786 deleted
New commits:
removing some unicode dashes from the doc