Opened 6 years ago

Closed 6 years ago

#20476 closed enhancement (fixed)

change some divisions to floor divisions

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: algebra Keywords: python3
Cc: Travis Scrimshaw, Jeroen Demeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 06a7690 (Commits, GitHub, GitLab) Commit: 06a76907f0f454684b60435a9c3073ad15e9f216
Dependencies: Stopgaps:

Status badges

Description

in the same spirit as #20471, to prepare for python3

Change History (5)

comment:1 Changed 6 years ago by Frédéric Chapoton

Branch: u/chapoton/20476
Commit: e5b2827fbe6b85585a36b9dc7e30eea1f6a529d1
Status: newneeds_review

New commits:

8a6418dsome changes related to classic division
b3527ceadding from future import division
e5b2827handling the case of hall algebras

comment:2 Changed 6 years ago by Frédéric Chapoton

Cc: Travis Scrimshaw Jeroen Demeyer added

comment:3 Changed 6 years ago by git

Commit: e5b2827fbe6b85585a36b9dc7e30eea1f6a529d106a76907f0f454684b60435a9c3073ad15e9f216

Branch pushed to git repo; I updated commit sha1. New commits:

06a7690division in linear_code.py

comment:4 Changed 6 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 6 years ago by Volker Braun

Branch: u/chapoton/2047606a76907f0f454684b60435a9c3073ad15e9f216
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.