Opened 3 years ago
Closed 3 years ago
#20475 closed enhancement (fixed)
Upgrade to Pynac0.6.5
Reported by:  rws  Owned by:  

Priority:  blocker  Milestone:  sage7.2 
Component:  packages: standard  Keywords:  
Cc:  Merged in:  
Authors:  Ralf Stephan, Benjamin Hackl, Aaditya Thakkar  Reviewers:  Eric Gourgoulhon, Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  72d96a5 (Commits)  Commit:  72d96a52202b450308a7626dcc80bfa7b6db3c10 
Dependencies:  #20312  Stopgaps: 
Description
That Pynac version has:
 fix for:
assume(x>0)
sets integer flag (#20456)  fix Maxima crashes by implementing fast Hermite (#20297) and Gegenbauer (#20428) polynomials in Pynac
 some fixes to handling of elements of rings with positive characteristics (#20162)
 Python 3 build fix
 automatic trigonometric and log simplifications
https://github.com/pynac/pynac/releases/download/pynac0.6.5/pynac0.6.5.tar.bz2
Change History (17)
comment:1 Changed 3 years ago by
 Branch set to u/rws/upgrade_to_pynac_0_6_5
comment:2 Changed 3 years ago by
 Commit set to 11e2b784979cf02d939c04ba0b029dfda92b0570
 Status changed from new to needs_review
comment:3 followup: ↓ 5 Changed 3 years ago by
 Status changed from needs_review to needs_work
I consider this a bug:
sage: S.<y> = PolynomialRing(RR) sage: hermite(3,y) 8*y^3  12*y
comment:4 Changed 3 years ago by
Does Sage use Ginac for other polynomial functions?
comment:5 in reply to: ↑ 3 ; followup: ↓ 6 Changed 3 years ago by
 Dependencies set to #20312
comment:6 in reply to: ↑ 5 ; followup: ↓ 7 Changed 3 years ago by
Replying to rws:
No. So?
Because we should look for a solution which would work generally for all polynomial symbolic functions.
For this ticket, I suggest to remove the changes to the hermite function since that's probably not easily fixed.
comment:7 in reply to: ↑ 6 Changed 3 years ago by
Replying to jdemeyer:
Replying to rws:
No. So?
Because we should look for a solution which would work generally for all polynomial symbolic functions.
The problem has nothing to do with just polynomial symbolic functions. See the example in #20312 or #20060.
For this ticket, I suggest to remove the changes to the hermite function since that's probably not easily fixed.
I intend to try to fix this (EDIT: I mean #20312), so any hints from you would be welcome.
comment:8 Changed 3 years ago by
 Commit changed from 11e2b784979cf02d939c04ba0b029dfda92b0570 to 024924e3bf37436b84a72c20be499e5322d86434
Branch pushed to git repo; I updated commit sha1. New commits:
e06a26c  Merge branch 'develop' into t/20475/upgrade_to_pynac_0_6_5

eb5bf93  20312: preserving function arg parent, first version

8f91703  Merge branch 'u/rws/parent_of_argument_lost_with_functions' of git://trac.sagemath.org/sage into t/20475/upgrade_to_pynac_0_6_5

1986ca5  fix to make fixed doctest pass

5c377cc  20312: fix for constant results

024924e  Merge branch 'u/rws/parent_of_argument_lost_with_functions' of git://trac.sagemath.org/sage into t/20475/upgrade_to_pynac_0_6_5

comment:9 Changed 3 years ago by
 Status changed from needs_work to needs_review
comment:10 Changed 3 years ago by
 Commit changed from 024924e3bf37436b84a72c20be499e5322d86434 to 72d96a52202b450308a7626dcc80bfa7b6db3c10
Branch pushed to git repo; I updated commit sha1. New commits:
72d96a5  Merge branch 'develop' into t/20475/upgrade_to_pynac_0_6_5

comment:11 Changed 3 years ago by
 Reviewers set to Eric Gourgoulhon
I gave a try and it looks good to me. It would be nice if this is merged in Sage 7.2 before the final release, to correct #20456 (a rather severe bug IMHO). @jdemeyer: do you agree to set the ticket to positive review?
comment:12 Changed 3 years ago by
 Priority changed from major to blocker
comment:13 Changed 3 years ago by
sage coverage says:
SCORE src/sage/symbolic/pynac.pyx: 97.4% (37 of 38) Missing doctests: * line 2271: def init_function_table()
comment:14 followup: ↓ 15 Changed 3 years ago by
Come on, we didn't have a doctest for this since it was added 6 years ago and I don't think we need one. Most of these functions aren't used anyway because the Function
code already bypasses Pynac with FP evaluation, and Pynac itself does not need it.
comment:15 in reply to: ↑ 14 Changed 3 years ago by
Replying to rws:
Come on, we didn't have a doctest for this since it was added 6 years ago and I don't think we need one. Most of these functions aren't used anyway because the
Function
code already bypasses Pynac with FP evaluation, and Pynac itself does not need it.
OK, I see.
comment:16 Changed 3 years ago by
 Reviewers changed from Eric Gourgoulhon to Eric Gourgoulhon, Volker Braun
 Status changed from needs_review to positive_review
comment:17 Changed 3 years ago by
 Branch changed from u/rws/upgrade_to_pynac_0_6_5 to 72d96a52202b450308a7626dcc80bfa7b6db3c10
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
new version/chksum
doctest changes and a few fixes in support of pynac0.6.5