Opened 5 years ago

Closed 5 years ago

#20468 closed enhancement (fixed)

changing some classic division to exact division in ascii_art of trees

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: combinatorics Keywords: python3, ascii_art
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7f7a7b5 (Commits, GitHub, GitLab) Commit: 7f7a7b5da4d6e134120bd3f2755519dfcef77b88
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

some problems (about future transition to py3) can be found using

python -Qwarnall $(which sage-runtests) src/sage/combinat/*.py 

let us try to correct a few of them.

see also #18659 and #15995

Change History (7)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/20468
  • Commit set to 1ab50b762be4cad278074d64736ad28ab05e7e02
  • Keywords python3 ascii_art added
  • Status changed from new to needs_review

New commits:

1ab50b7changing some division into exact division in ascii_art

comment:2 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Since you're changing it, you might as well do:

-while len(roots):
+while roots:

Once you make those changes, you can set it to a positive review.

comment:3 Changed 5 years ago by git

  • Commit changed from 1ab50b762be4cad278074d64736ad28ab05e7e02 to 7f7a7b5da4d6e134120bd3f2755519dfcef77b88

Branch pushed to git repo; I updated commit sha1. New commits:

7f7a7b5trac 20468 reviewer's suggestion

comment:4 Changed 5 years ago by chapoton

  • Description modified (diff)
  • Status changed from needs_review to positive_review

thanks Travis

comment:5 Changed 5 years ago by chapoton

sequel in #20471

comment:6 Changed 5 years ago by jdemeyer

General suggestion: add from __future__ import division on top of modules which have been fully converted. That way we know for sure that there are no old-style divisions left in that module.

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/20468 to 7f7a7b5da4d6e134120bd3f2755519dfcef77b88
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.