Opened 7 years ago
Last modified 8 months ago
#20466 needs_work defect
Can't multiply continued fractions
Reported by: | Karl-Dieter Crisman | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-wishlist |
Component: | number theory | Keywords: | continued_fraction |
Cc: | Vincent Delecroix, Samuel Lelièvre, Thierry Monteil | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
There has been some reimplementation on here, so maybe this is no longer true, but this ask.sagemath post anyway points out
sage: x = continued_fraction(pi) sage: y = 3*x TypeError: unsupported operand parent(s) for '*': 'Integer Ring' and '<class 'sage.rings.continued_fraction.ContinuedFraction_real'>'
Change History (9)
comment:1 Changed 7 years ago by
Cc: | Vincent Delecroix Samuel Lelièvre Thierry Monteil added |
---|---|
Keywords: | continued_fraction added |
comment:2 Changed 7 years ago by
comment:3 Changed 2 years ago by
Milestone: | sage-7.2 → sage-duplicate/invalid/wontfix |
---|---|
Status: | new → needs_review |
maybe we can close as duplicate ?
comment:4 Changed 2 years ago by
Why would you? #19120 does not implement the full gosper algorithm for (a xy + b x + cy + d) / (e xy + f x + g y + h)
but only (ax + b) / (cx + d)
.
comment:6 Changed 2 years ago by
indeed. Y a un algo pour multiplier deux fractions continues quelconques ?
comment:7 Changed 2 years ago by
Milestone: | sage-duplicate/invalid/wontfix → sage-wishlist |
---|---|
Status: | needs_review → needs_work |
comment:9 Changed 8 months ago by
some code in C can be seen here
https://github.com/mjdominus/cf/blob/master/cf_arith.c
and some explanations here
Note: See
TracTickets for help on using
tickets.
See #19120