Opened 6 years ago
Closed 6 years ago
#20459 closed defect (fixed)
remove a few instances of == False and == True in /combinat
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-7.2 |
Component: | combinatorics | Keywords: | |
Cc: | tscrim, jdemeyer | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | a657d83 (Commits, GitHub, GitLab) | Commit: | a657d8363b837a78f7944c1d04f98715d538ed4e |
Dependencies: | Stopgaps: |
Description
Let us remove some bad uses of comparison to True or False.
Change History (6)
comment:1 Changed 6 years ago by
- Branch set to public/20459
- Cc tscrim jdemeyer added
- Commit set to 36ccb1877b19ca9d308be7c951fdaeaac49bea3d
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Status changed from needs_review to needs_work
There are some issues noted by the patchbots:
sage -t --long src/sage/combinat/finite_state_machine.py # 2 doctests failed
comment:3 Changed 6 years ago by
- Commit changed from 36ccb1877b19ca9d308be7c951fdaeaac49bea3d to a657d8363b837a78f7944c1d04f98715d538ed4e
Branch pushed to git repo; I updated commit sha1. New commits:
a657d83 | trac 20459 fixing the finite state machine doctests
|
comment:4 Changed 6 years ago by
- Status changed from needs_work to needs_review
comment:5 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
comment:6 Changed 6 years ago by
- Branch changed from public/20459 to a657d8363b837a78f7944c1d04f98715d538ed4e
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
not using == False in /combinat
not using == True in /combinat