Opened 3 years ago

Closed 3 years ago

#20457 closed defect (fixed)

Fix teichmuller_system method for p-adic extension

Reported by: mmasdeu Owned by:
Priority: major Milestone: sage-7.3
Component: padics Keywords: padics, teichmuller, residue field
Cc: roed, kedlaya Merged in:
Authors: Marc Masdeu Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 697a29e (Commits) Commit: 697a29e2bd8ffbf37b1021878beead90b518fd33
Dependencies: Stopgaps:

Description

The following does not currently work:

sage: F.<a> = Qq(5^2,10)
sage: F.teichmuller_system()

I propose an easy patch that fixes this, although the long-term solution would be to fix the method lift() for elements in F.residue_field().

Change History (9)

comment:1 Changed 3 years ago by mmasdeu

  • Branch set to u/mmasdeu/20457-teichmuller-system
  • Commit set to 236947f8e95875c33920295fc814bbd1dcdbf6bd
  • Status changed from new to needs_review

New commits:

236947fTrac #20457: fixed teichmuller_system method.

comment:2 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

This line should end with two colons

Check that :trac:`20457` is fixed:

comment:3 Changed 3 years ago by kedlaya

  • Cc kedlaya added

comment:4 Changed 3 years ago by git

  • Commit changed from 236947f8e95875c33920295fc814bbd1dcdbf6bd to 697a29e2bd8ffbf37b1021878beead90b518fd33

Branch pushed to git repo; I updated commit sha1. New commits:

697a29eFixed one line in doctest.

comment:5 Changed 3 years ago by mmasdeu

  • Status changed from needs_work to needs_review

comment:6 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, good enough

comment:7 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

comment:8 Changed 3 years ago by chapoton

  • Milestone changed from sage-7.2 to sage-7.3

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/mmasdeu/20457-teichmuller-system to 697a29e2bd8ffbf37b1021878beead90b518fd33
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.