Opened 2 years ago
Closed 23 months ago
#20451 closed defect (fixed)
error in projective canonical height
Reported by: | bhutz | Owned by: | bhutz |
---|---|---|---|
Priority: | minor | Milestone: | sage-7.2 |
Component: | algebraic geometry | Keywords: | |
Cc: | rlmiller | Merged in: | |
Authors: | Ben Hutz | Reviewers: | Rebecca Lauren Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | b3212fa (Commits) | Commit: | b3212fa80172a6ef3b6b1c0cebe0cbe0c9a1737b |
Dependencies: | Stopgaps: |
Description
The error bound for canonical height is not working in all cases.
PS.<x,y>=ProjectiveSpace(1,QQ) H=Hom(PS,PS) f=H([16*x^2 -29*y^2,16*y^2]) #Poonen 3-cycle Q=PS([-1/4,1]) Q.is_preperiodic(f)
is using error_bound = 0.01 and getting an error larger than 0.01
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to u/bhutz/ticket/20451
- Commit set to b3212fa80172a6ef3b6b1c0cebe0cbe0c9a1737b
- Status changed from new to needs_review
comment:2 Changed 23 months ago by
- Cc rlmiller added
comment:3 Changed 23 months ago by
- Status changed from needs_review to positive_review
Looks good to me!
comment:4 Changed 23 months ago by
- Status changed from positive_review to needs_work
Reviewer name is missing
comment:5 Changed 23 months ago by
- Reviewers set to Rebecca Lauren Miller
comment:6 Changed 23 months ago by
- Status changed from needs_work to positive_review
comment:7 Changed 23 months ago by
- Branch changed from u/bhutz/ticket/20451 to b3212fa80172a6ef3b6b1c0cebe0cbe0c9a1737b
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
there were errors in two places. One with how resultant was called (and in resultant itself) with respect to normalization, and a problem with how the error bound was calculated.
New commits:
20451: fix error_bound for projective canonical height