Opened 5 years ago

Closed 5 years ago

#20443 closed enhancement (fixed)

decoder_type method does not work on uninstantiated Decoder classes

Reported by: dlucas Owned by:
Priority: major Milestone: sage-7.4
Component: coding theory Keywords: sd75
Cc: jsrn Merged in:
Authors: David Lucas Reviewers: Daniel Augot
Report Upstream: N/A Work issues:
Branch: 771f3fe (Commits, GitHub, GitLab) Commit: 771f3fee348ec72cbbcc43ef292e01e3c36fa5ae
Dependencies: Stopgaps:

Status badges

Description

The method decoder_type for Decoder objects is supposed to work on uninstantiated classes to allow the user to check the types of a decoder without being forced to construct it beforehand.

This ticket proposes a change for decoder_type so it now works on both uninstantiated classes and instances.

Change History (7)

comment:1 Changed 5 years ago by dlucas

  • Branch set to u/dlucas/decoder_type_method_for_uninstanciated_classes

comment:2 Changed 5 years ago by dlucas

  • Authors set to David Lucas
  • Commit set to 771f3fee348ec72cbbcc43ef292e01e3c36fa5ae
  • Status changed from new to needs_review

I pushed the patch, this is now open for review.

David


New commits:

771f3fedecoder_type works now properly on uninstantiated classes

comment:3 Changed 5 years ago by danielaugot

Hi David,

I tested this for the 11 decoders I found using codes.decoders.<TAB> and it worked fine.

I set the ticket status to positive review.

Daniel

comment:4 Changed 5 years ago by danielaugot

  • Status changed from needs_review to positive_review

comment:5 Changed 5 years ago by tscrim

  • Milestone changed from sage-7.2 to sage-7.4
  • Status changed from positive_review to needs_work

Reviewer (real) name.

comment:6 Changed 5 years ago by jsrn

  • Keywords sd75 added
  • Reviewers set to Daniel Augot
  • Status changed from needs_work to positive_review

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/dlucas/decoder_type_method_for_uninstanciated_classes to 771f3fee348ec72cbbcc43ef292e01e3c36fa5ae
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.