Opened 6 years ago

Closed 6 years ago

#20441 closed enhancement (fixed)

Fast conversion ℚ[√a] → arb balls

Reported by: mmezzarobba Owned by:
Priority: major Milestone: sage-7.2
Component: number fields Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Fredrik Johansson
Report Upstream: N/A Work issues:
Branch: f8e16b6 (Commits, GitHub, GitLab) Commit: f8e16b68014544b96698dc11c8fa90e4a187e3d3
Dependencies: Stopgaps:

Status badges

Description

Before:

sage: QQi.<i> = QuadraticField(-1)
sage: %timeit CBF(i)
The slowest run took 5.04 times longer than the fastest. This could mean that an intermediate result is being cached.
100 loops, best of 3: 2.45 ms per loop
sage: NF.<a> = QuadraticField(2)
sage: RBF((a-1)^100)
[+/- 3.78e+22]

After:

sage: QQi.<i> = QuadraticField(-1)
sage: %timeit CBF(i)
The slowest run took 1175.13 times longer than the fastest. This could mean that an intermediate result is being cached.
1000000 loops, best of 3: 791 ns per loop
sage: NF.<a> = QuadraticField(2)
sage: RBF((a-1)^100)
[5.27753918069144e-39 +/- 2.15e-54]

Change History (8)

comment:1 Changed 6 years ago by mmezzarobba

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by mmezzarobba

  • Component changed from numerical to number fields

comment:3 Changed 6 years ago by fredrik.johansson

  • Reviewers set to Fredrik Johansson
  • Status changed from needs_review to positive_review

Nothing to complain about.

comment:4 Changed 6 years ago by vbraun

Nice commit message ;-)

comment:5 Changed 6 years ago by mmezzarobba

Thanks for the review!

comment:6 Changed 6 years ago by git

  • Commit changed from ba857dd9802f7712838cbd15896a8ac755a0a503 to f8e16b68014544b96698dc11c8fa90e4a187e3d3
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

f8e16b6misplaced fmpz_clear

comment:7 Changed 6 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

Oops, I just noticed that I used a flint integer after clearing it. Since the tests still pass, I am taking the liberty to set the ticket back to positive_review.

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/mmezzarobba/QNFelt_to_ball to f8e16b68014544b96698dc11c8fa90e4a187e3d3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.