Opened 6 years ago

Last modified 3 weeks ago

#20434 new defect

LatticePoset() arguments not forwarded to Poset()

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-9.7
Component: combinatorics Keywords: poset
Cc: kdilks Merged in:
Authors: Jori Mäntysalo Reviewers:
Report Upstream: N/A Work issues:
Branch: public/posets/forwarding_args_from_lattices-20434 (Commits, GitHub, GitLab) Commit: 0fd62bc3177e90d41e0d85c6d2eaf4e92558100c
Dependencies: Stopgaps:

Status badges

Description

Docstring of LatticePoset() says that **options if forwarded to Poset(). It is not:

sage: P = Poset( ([0, 1,3,2, 10], [[0,1],[0,3],[0,2], [1,10],[3,10],[2,10]]), linear_extension=True)
sage: L = LatticePoset( ([0, 1,3,2, 10], [[0,1],[0,3],[0,2], [1,10],[3,10],[2,10]]), linear_extension=True)
sage: P.list()
[0, 1, 3, 2, 10]
sage: L.list()
[0, 1, 2, 3, 10]

Change History (11)

comment:1 Changed 6 years ago by jmantysalo

This can be seen also with plain posets:

P1 = Poset({1:[2]}, linear_extension=False, facade=False)
P2 = Poset(P1)
Q1 = Poset({1:[2]}, linear_extension=True, facade=True)
Q2 = Poset(Q1)
print P1._with_linear_extension, P1._is_facade, "-->", P2._with_linear_extension, P2._is_facade
print Q1._with_linear_extension, Q1._is_facade, "-->", Q2._with_linear_extension, Q2._is_facade

outputs

False False --> False False
True True --> False True

i.e. linear_extension=True is not copied along the data and facade argument.

I suppose that this relates to #18776.

Last edited 6 years ago by jmantysalo (previous) (diff)

comment:2 Changed 6 years ago by jmantysalo

  • Cc kdilks added

Kevin, want to look at this?

As of my previous comment: Travis noticed at sage-devel that linear_extension=False is the default, whereas default for facade is None.

comment:3 Changed 6 years ago by jmantysalo

  • Authors set to Jori Mäntysalo
  • Dependencies set to #21666

#21666 will conflict, added as dependency.

comment:4 Changed 6 years ago by jmantysalo

  • Branch set to u/jmantysalo/faster-DivisorLattice

comment:5 Changed 6 years ago by jmantysalo

  • Commit set to 5ae54b3cc5b1ce336cd4d8e1fcefb84119f1ccf0
  • Milestone changed from sage-7.2 to sage-7.5

Duh. I did something really wrong with git and trac.

Waiting for 7.5 beta.


New commits:

8ee46bcModify DivisorLattice(n).
87bd385Parentheses from import.
5ae54b3Make LatticePoset(..., linear_extension=True) work.

comment:6 Changed 6 years ago by tscrim

  • Branch changed from u/jmantysalo/faster-DivisorLattice to public/posets/forwarding_args_from_lattices-20434
  • Commit changed from 5ae54b3cc5b1ce336cd4d8e1fcefb84119f1ccf0 to 0fd62bc3177e90d41e0d85c6d2eaf4e92558100c
  • Dependencies #21666 deleted

Fixing the branch issues with #21666.


New commits:

0fd62bcMake LatticePoset(..., linear_extension=True) work.

comment:7 Changed 20 months ago by chapoton

  • Keywords poset added
  • Milestone changed from sage-7.5 to sage-9.3

comment:8 Changed 16 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:9 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

comment:10 Changed 5 months ago by mkoeppe

  • Milestone changed from sage-9.5 to sage-9.6

comment:11 Changed 3 weeks ago by mkoeppe

  • Milestone changed from sage-9.6 to sage-9.7
Note: See TracTickets for help on using tickets.