Opened 4 years ago

Closed 4 years ago

#20425 closed defect (fixed)

bug in reducible Coxeter types init

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.2
Component: combinatorics Keywords: coxeter
Cc: tscrim, stumpc5 Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 13f3fa5 (Commits) Commit: 13f3fa53f681aed5c40f762d5932050162c59870
Dependencies: Stopgaps:

Description (last modified by chapoton)

here: 

sage: W=CoxeterGroup(('A1',['H',3]))

is not working. This comes from 

sage: from sage.groups.matrix_gps.coxeter_group import *
sage: Z=CartanType(('A1',['H',3]))
sage: CoxeterMatrixGroup(Z)

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Description modified (diff)

comment:2 Changed 4 years ago by tscrim

  • Authors set to Travis Scrimshaw
  • Branch set to public/combinat/fix_reducible_coxeter_types-20425
  • Cc stumpc5 added
  • Commit set to 13f3fa53f681aed5c40f762d5932050162c59870
  • Status changed from new to needs_review

New commits:

​13f3fa5Implementing a coxeter_diagram for reducible Cartan/Coxeter types.

comment:3 Changed 4 years ago by tscrim

The problem was that reducible Cartan types did not have a coxeter_diagram. For crystallographic types, there was an implementation that used the Dynkin diagram, but that did not extend for the case given in this ticket description.

comment:4 Changed 4 years ago by chapoton

  • Keywords coxeter added
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

good to go

thanks, Travis

comment:5 Changed 4 years ago by vbraun

  • Branch changed from public/combinat/fix_reducible_coxeter_types-20425 to 13f3fa53f681aed5c40f762d5932050162c59870
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.