Opened 5 years ago

Closed 5 years ago

#20422 closed defect (fixed)

Fix conversions matrix -> AffineGroup

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.2
Component: group theory Keywords:
Cc: vbraun Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: d9f8bde (Commits, GitHub, GitLab) Commit: d9f8bdee1447c80a0ecda4e31ee7675d3832775e
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Conversion from a matrix representing an affine transformation to an affine group element only works in dimension 2 (due to a hard-coded 2 in __init__). Conversion from a matrix group element to an affine group element also does not work.

Change History (7)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/20422

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to d9f8bdee1447c80a0ecda4e31ee7675d3832775e
  • Description modified (diff)

New commits:

d9f8bdeFix conversions matrix -> AffineGroup

comment:3 Changed 5 years ago by jdemeyer

  • Cc vbraun added
  • Status changed from new to needs_review

comment:4 Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, looks good to me

comment:5 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

comment:6 Changed 5 years ago by jdemeyer

Thanks!

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/20422 to d9f8bdee1447c80a0ecda4e31ee7675d3832775e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.