Opened 5 years ago

Closed 5 years ago

#20419 closed defect (fixed)

Fix type recognition of Coxeter matrix

Reported by: tscrim Owned by:
Priority: major Milestone: sage-7.2
Component: combinatorics Keywords:
Cc: sage-combinat, nthiery, chapton, darij, stumpc5 Merged in:
Authors: Travis Scrimshaw Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: 56e5127 (Commits, GitHub, GitLab) Commit: 56e5127918730241c71709510b170cfc2ad571b4
Dependencies: Stopgaps:

Status badges

Description

We have type A -> B -> G:

sage: M = CoxeterMatrix(['A',2])
sage: CoxeterMatrix(matrix(M)).coxeter_type()
Coxeter type of ['B', 2]
sage: M = CoxeterMatrix(['B',2])
sage: CoxeterMatrix(matrix(M)).coxeter_type()
Coxeter type of ['G', 2]

Change History (5)

comment:1 Changed 5 years ago by tscrim

  • Authors set to Travis Scrimshaw
  • Branch set to public/combinat/fix_type_recognitin_coxeter_matrix-20419
  • Commit set to 56e5127918730241c71709510b170cfc2ad571b4
  • Status changed from new to needs_review

New commits:

56e5127Fixing rank 2 type recognition.

comment:2 Changed 5 years ago by tscrim

This occurred only in rank 2, and we were just not checking the entries correctly.

comment:3 Changed 5 years ago by darij

Congrats, this is the first ticket I've been able to review from a tablet.

If all tests pass, please set to positive review!

comment:4 Changed 5 years ago by tscrim

  • Reviewers set to Darij Grinberg
  • Status changed from needs_review to positive_review

Thanks.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from public/combinat/fix_type_recognitin_coxeter_matrix-20419 to 56e5127918730241c71709510b170cfc2ad571b4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.