Opened 6 years ago

Closed 6 years ago

#20418 closed enhancement (fixed)

Fix comparison of reducible Cartan types

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-7.2
Component: combinatorics Keywords:
Cc: sage-combinat, nthiery, stumpc5, chapoton Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: b55338c (Commits, GitHub, GitLab) Commit: b55338c3f151de7e4ad8f39d525bdd5c34178cd6
Dependencies: Stopgaps:

Status badges


This currently breaks:

sage: ct = CartanType(["A2", "B2"])
sage: ct == (1, 2, 1)

due to __cmp__ of reducible Cartan type not doing enough checking.

Change History (4)

comment:1 Changed 6 years ago by tscrim

  • Branch set to public/combinat/fix_cmp_reducible_cartan_type-20418
  • Commit set to b55338c3f151de7e4ad8f39d525bdd5c34178cd6
  • Status changed from new to needs_review

New commits:

b55338cFixing __cmp__ for reducible Cartan types.

comment:2 Changed 6 years ago by chapoton

  • Status changed from needs_review to positive_review

looks good to me

comment:3 Changed 6 years ago by tscrim

  • Reviewers set to Frédéric Chapoton

comment:4 Changed 6 years ago by vbraun

  • Branch changed from public/combinat/fix_cmp_reducible_cartan_type-20418 to b55338c3f151de7e4ad8f39d525bdd5c34178cd6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.