Opened 3 years ago

Closed 3 years ago

#20417 closed enhancement (fixed)

Improve speed of CoxeterGroup as a matrix group

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-7.2
Component: group theory Keywords:
Cc: sage-combinat, stumpc5, chapoton, nthiery Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: bf7164a (Commits) Commit: bf7164aa677727c22d8cca72ef10f563e2d78745
Dependencies: Stopgaps:

Description

We only need to check for the first non-zero entry to determine if there is a descent in position i.

Change History (5)

comment:1 Changed 3 years ago by tscrim

  • Branch set to public/groups/speedup_descents_coxeter_groups-20417
  • Commit set to ebb3d12809a2cbb523b7a15b4255abdb50dc603f
  • Status changed from new to needs_review

New commits:

ebb3d12Increasing speed for matrix group version of Coxeter groups.

comment:2 Changed 3 years ago by stumpc5

_matrix_test_right_descent(M, i, n, zero) should raise an error if the for loop ends without finding an element.

comment:3 Changed 3 years ago by git

  • Commit changed from ebb3d12809a2cbb523b7a15b4255abdb50dc603f to bf7164aa677727c22d8cca72ef10f563e2d78745

Branch pushed to git repo; I updated commit sha1. New commits:

bf7164atrac #20417 assertion error

comment:4 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

looks good to me

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/groups/speedup_descents_coxeter_groups-20417 to bf7164aa677727c22d8cca72ef10f563e2d78745
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.